[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-27 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-27 Thread Stefan Behnel
Stefan Behnel added the comment: I don't think this should be backported. Pretty-printing is not a production relevant feature, more of a "debugging, diffing and help users see what they get" kind of feature. It's good to have it fixed for the future, but we shouldn't bother users with it du

[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-26 Thread miss-islington
Change by miss-islington : -- pull_requests: +12522 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Should we backport this change? I am not sure. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 384b81d923addd52125e94470b11d2574ca266a9 by Serhiy Storchaka (Vladimir Surjaninov) in branch 'master': bpo-36407: Fix writing indentations of CDATA section (xml.dom.minidom). (GH-12514) https://github.com/python/cpython/commit/384b81d923addd5

[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-23 Thread Stefan Behnel
Stefan Behnel added the comment: Yes, this case is incorrect. Pretty printing should not change character content inside of a simple tag. The PR looks good to me. -- versions: +Python 3.8 ___ Python tracker __

[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-23 Thread Vladimir Surjaninov
Change by Vladimir Surjaninov : -- keywords: +patch pull_requests: +12465 stage: -> patch review ___ Python tracker ___ ___ Python-

[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-23 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +eli.bendersky, scoder, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list m

[issue36407] xml.dom.minidom wrong indentation writing for CDATA section

2019-03-23 Thread Vladimir Surjaninov
New submission from Vladimir Surjaninov : If we are writing xml with CDATA section and leaving non-empty indentation and new-line parameters, a parent node of the section will contain useless indentation, that will be parsed as a text. Example: >>>doc = minidom.Document() >>>root = doc.createE