[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

STINNER Victor added the comment: Ok, thanks Berker for your longer answer. I have no opinion on this example anymore. Stéphane and others: I let you decide how to handle it ;-) -- ___ Python tracker ___

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Berker Peksag added the comment: > I looked at other examples: they are nice but far from a "real application". You can use the same argument for pretty much every example in the stdlib documentation :) wsgiref is a low level module, users should use projects like WebOb instead. Also, a com

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

STINNER Victor added the comment: Berker Peksag: > Please revert 360e1e4c519cfc139de707bcdd1e6c871eec79ee. It's not a good > example to put into the documentation. I looked at other examples: they are nice but far from a "real application". I like the last example which combines multiple wsg

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Berker Peksag added the comment: Please revert 360e1e4c519cfc139de707bcdd1e6c871eec79ee. It's not a good example to put into the documentation. It uses different naming convention. It would only confuse users relatively new to the wsgiref module and WSGI protocol. FileWrapper was supposed t

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Change by Stéphane Wirtel : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Change by Stéphane Wirtel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Stéphane Wirtel added the comment: New changeset 2b7f93b99afbe78e4e567d9252d9470d29f387c8 by Stéphane Wirtel in branch 'master': bpo-36345: Update wsgiref example (GH-12562) https://github.com/python/cpython/commit/2b7f93b99afbe78e4e567d9252d9470d29f387c8 --

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Brett Cannon added the comment: I actually still think we should remove serve.py as the person who had needed to clean up that directory when we realized we had massive bitrot in /Tools. :) I don't' think that just because Debian packages means we need to continue supporting and maintaining

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Change by Stéphane Wirtel : -- pull_requests: +12507 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

STINNER Victor added the comment: Would it me sense to use ".. literalinclude:: ../../Tools/scripts/serve.py" in the wsgi doc to keep serve.py and and this example up to date? It seems like serve.py is going to stay. -- ___ Python tracker

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Stéphane Wirtel added the comment: Thank you for the merge. Stéphane -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Brett Cannon added the comment: New changeset 360e1e4c519cfc139de707bcdd1e6c871eec79ee by Brett Cannon (Stéphane Wirtel) in branch 'master': bpo-36345: Add a new example in the documentation of wsgiref (#12511) https://github.com/python/cpython/commit/360e1e4c519cfc139de707bcdd1e6c871eec79ee

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Ned Deily added the comment: Just dropping part-1 is fine with me, thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Stéphane Wirtel added the comment: Hi Ned, There are 3 PRs, part-0, part-1 and part-2 We can ignore the part-1, this one remove serve.py and the two others are independent. -- ___ Python tracker __

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Ned Deily added the comment: The files in the Tools directory are installed on user systems by various distributions: for example, in Debian, as part of the python3.x-examples package and by the macOS python.org installer. If you move serve.py, it will no longer be available to end users th

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Change by Stéphane Wirtel : -- pull_requests: +12473 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

STINNER Victor added the comment: Maybe others prefer to do both changes at once. I don't know. -- ___ Python tracker ___ ___ Pytho

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

STINNER Victor added the comment: I would remove to move the script into the doc in 1 PR and just modify Makefile in the other one. So the Makefile can be updated first. -- ___ Python tracker ___

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Stéphane Wirtel added the comment: @vstinner I propose two PRs. The first one will remove the Tools/scripts/serve.py file and update the Makefile. The second and independent PR just add a new example in the documentation of wsgiref, the example is based on Tools/scripts/serve.py --

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Change by Stéphane Wirtel : -- pull_requests: +12462 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

STINNER Victor added the comment: > with your suggestions, I will move the serve.py in the documentation of > wsgiref and change Doc/Makefile. I suggest to write two separated PRs for each change. -- ___ Python tracker

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Brett Cannon added the comment: I agree that if it's a good example of using wsgiref then it should exist in the wsgiref docs as an example. Then that would mean dropping the script and updating the Makefile. -- nosy: +brett.cannon ___ Python trac

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Julien Palard added the comment: If it's appreciated as a demo for wsgiref, wouldn't it be better to move it inside Doc/library/wsgiref.rst? It was written specifically for the Doc/Makefile, it's no longer needed for the Doc/Makefile, so the question pops: is it usefull to anyone? If not it'

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Serhiy Storchaka added the comment: I disagree with deprecating serve.py. It is a demo for the wsgiref module. -- nosy: +serhiy.storchaka ___ Python tracker ___ __

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

STINNER Victor added the comment: I'm ok with modifying "make server" to reuse http.server, but I'm not sure about deprecating Tools/scripts/serve.py. serve.py uses wsgiref which is different than http.server. Does anyone use it? I would prefer to keep it. If you want to remove it, please se

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Change by Stéphane Wirtel : -- keywords: +patch pull_requests: +12362 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

Change by Stéphane Wirtel : -- nosy: +mdk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

New submission from Stéphane Wirtel : The Makefile of Doc/ has a `serve` target. Currently, this one uses `Tools/scripts/serve.py`. But since 3.7, this script could be replaced by `python -m http.server -d directory`. @mdk and myself thinking we could deprecate `Tools/scripts/serve.py` with a