[issue36274] http.client cannot send non-ASCII request lines

Change by Larry Hastings : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36274] http.client cannot send non-ASCII request lines

Larry Hastings added the comment: New changeset 2784e78dc3445c6dd59e915d86c336374c1fa09a by larryhastings (Jason R. Coombs) in branch '3.5': [3.5] bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16448) (#16475) https://github.com/python/cpyt

[issue36274] http.client cannot send non-ASCII request lines

Benjamin Peterson added the comment: New changeset f5b1abbb3b0083381925dcd5898ae6d019224826 by Benjamin Peterson (Jason R. Coombs) in branch '2.7': [2.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16476) https://github.com/python/cpytho

[issue36274] http.client cannot send non-ASCII request lines

Change by Jason R. Coombs : -- pull_requests: +16062 pull_request: https://github.com/python/cpython/pull/16476 ___ Python tracker ___ _

[issue36274] http.client cannot send non-ASCII request lines

Change by Jason R. Coombs : -- pull_requests: +16060 pull_request: https://github.com/python/cpython/pull/16475 ___ Python tracker ___ _

[issue36274] http.client cannot send non-ASCII request lines

Ned Deily added the comment: New changeset 5b18ce60b432d1dfa6f6988be07dd55646201a9b by Ned Deily (Jason R. Coombs) in branch '3.6': [3.6] bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16448) (GH-16462) https://github.com/python/cpython/com

[issue36274] http.client cannot send non-ASCII request lines

miss-islington added the comment: New changeset 8f478b489ae11633d2609dff0ef21d0e1a857417 by Miss Islington (bot) in branch '3.8': bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16448) https://github.com/python/cpython/commit/8f478b489ae1163

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: New changeset 80dd66ac278ecbabbf843526e3a56f5031da9562 by Jason R. Coombs in branch '3.7': [3.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16448) (GH-16461) https://github.com/python/cpython/commit/80

[issue36274] http.client cannot send non-ASCII request lines

Change by Jason R. Coombs : -- pull_requests: +16047 pull_request: https://github.com/python/cpython/pull/16462 ___ Python tracker ___ _

[issue36274] http.client cannot send non-ASCII request lines

Change by Jason R. Coombs : -- pull_requests: +16045 pull_request: https://github.com/python/cpython/pull/16461 ___ Python tracker ___ _

[issue36274] http.client cannot send non-ASCII request lines

Change by miss-islington : -- pull_requests: +16043 pull_request: https://github.com/python/cpython/pull/16460 ___ Python tracker ___ __

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: New changeset 7774d7831e8809795c64ce27f7df52674581d298 by Jason R. Coombs in branch 'master': bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16448) https://github.com/python/cpython/commit/7774d7831e880979

[issue36274] http.client cannot send non-ASCII request lines

Change by Jason R. Coombs : -- pull_requests: +16028 pull_request: https://github.com/python/cpython/pull/16448 ___ Python tracker ___ _

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: I should say, though, this issue is a long-standing regression from Python 3.0. Although intentional, the inability for a client to override the encoding of the request line does make it impossible without replacing all of .putrequest to override that behav

[issue36274] http.client cannot send non-ASCII request lines

Change by Jason R. Coombs : -- pull_requests: +15899 pull_request: https://github.com/python/cpython/pull/16321 ___ Python tracker ___ _

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: That's right - no longer a 3.7 regression here. -- keywords: -3.7regression ___ Python tracker ___

[issue36274] http.client cannot send non-ASCII request lines

Karthikeyan Singaravelan added the comment: > @xtreak the encoded null-byte test would be an extra test case to consider. > It is reasonable to test as many known invalid sequences as possible. > Changing that byte to encoded notation would just replace one test with > another effectively ch

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: I've created issue38216 to address the issue of sending invalid bytes in the request line, separate from the original intention and title issue about sending non-ASCII. -- ___ Python tracker

[issue36274] http.client cannot send non-ASCII request lines

Sviatoslav Sydorenko added the comment: @xtreak the encoded null-byte test would be an extra test case to consider. It is reasonable to test as many known invalid sequences as possible. Changing that byte to encoded notation would just replace one test with another effectively changing the s

[issue36274] http.client cannot send non-ASCII request lines

Karthikeyan Singaravelan added the comment: Is there a reason why cherrypy doesn't URL encode the null byte in this test as per comment : https://github.com/cherrypy/cherrypy/issues/1781#issuecomment-504476658 ? The original fix was adopted from golang (https://github.com/golang/go/commit/8

[issue36274] http.client cannot send non-ASCII request lines

Ned Deily added the comment: See msg352596 in Issue30458 for discussion of whether the regression should be considered a "release blocker" for the imminent 3.7.5 and 3.5.8 releases. -- keywords: +3.7regression nosy: +ned.deily ___ Python tracker <

[issue36274] http.client cannot send non-ASCII request lines

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue36274] http.client cannot send non-ASCII request lines

Change by Sviatoslav Sydorenko : -- nosy: +webknjaz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: As I considered a patch for this, I realized there are actually two issues, the one in the title "http.client cannot send non-ASCII request lines" but also "the protection for invalid requests prevents usage to generate invalid requests". The former issue w

[issue36274] http.client cannot send non-ASCII request lines

Change by Matej Cepl : -- nosy: +mcepl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: I've started drafting a patch at https://github.com/python/cpython/tree/feature/putrequest-hooks -- ___ Python tracker ___

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: I believe this issue is more recent and widespread than I originally thought. I realized today that CherryPy is affected by this issue and [disabled nightly tests](https://github.com/cherrypy/cherrypy/issues/1781#issuecomment-507836873) as a result. It look

[issue36274] http.client cannot send non-ASCII request lines

Tim Burke added the comment: Fair enough. Seems kinda related to https://bugs.python.org/issue30458 -- looks like it was a fun one ;-) I think either approach would work for me; my existing work-around doesn't preclude either, particularly since I want it purely for testing purposes. For a

[issue36274] http.client cannot send non-ASCII request lines

Jason R. Coombs added the comment: Thank you Tim for the reasoned issue and proposed solutions. After reviewing these proposals with @eric.snow, we've decided that this approach is dangerous in that the proposed approaches has the potential to expose users unexpectedly to non-compliant behav

[issue36274] http.client cannot send non-ASCII request lines

Change by Tim Burke : -- pull_requests: +12289 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue36274] http.client cannot send non-ASCII request lines

Change by Tim Burke : -- keywords: +patch pull_requests: +12288 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue36274] http.client cannot send non-ASCII request lines

Change by SilentGhost : -- nosy: +orsenthil versions: -Python 3.4, Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-li

[issue36274] http.client cannot send non-ASCII request lines

New submission from Tim Burke : While the RFCs are rather clear that non-ASCII data would be out of spec, * that doesn't prevent a poorly-behaved client from sending non-ASCII bytes on the wire, which means * as an application developer, it's useful to be able to mimic such a client to verify