[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-14 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the report Charalampos. I fixed dtoa.c in 2.7, 3.7 and master branches. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset b14057877fd897eaee7bc6626682fc6092b6bbd2 by Victor Stinner in branch '2.7': bpo-36262: Fix _Py_dg_strtod() memory leak (goto undfl) (GH-12276) (GH-12332) https://github.com/python/cpython/commit/b14057877fd897eaee7bc6626682fc6092b6bbd2 ---

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9818360ed94b39c4605951077b73ae798cddbfb9 by Victor Stinner in branch '3.7': bpo-36262: Fix _Py_dg_strtod() memory leak (goto undfl) (GH-12276) (GH-12331) https://github.com/python/cpython/commit/9818360ed94b39c4605951077b73ae798cddbfb9 ---

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12303 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12302 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9776b0636ae39668d3ce1c006d4be01dad01bf9f by Victor Stinner in branch 'master': bpo-36262: Fix _Py_dg_strtod() memory leak (goto undfl) (GH-12276) https://github.com/python/cpython/commit/9776b0636ae39668d3ce1c006d4be01dad01bf9f -- ___

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-11 Thread Mark Dickinson
Mark Dickinson added the comment: > ... in practice, it seems like Python became the "upstream". Yes; unfortunately, we changed things enough that updating from upstream became impractical. At some point we should take a look at changes made to the upstream dtoa.c since our adoption of it, a

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-11 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +12256 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-11 Thread STINNER Victor
STINNER Victor added the comment: Julia copied the same file. See: * https://bugs.llvm.org//show_bug.cgi?id=31928 * https://bugs.freebsd.org/216770 * https://bugs.python.org/issue30104: "It was decided to not touch dtoa.c to not diverge from upstream." -- ___

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-11 Thread STINNER Victor
STINNER Victor added the comment: * bpo-9009 discussed maintenance of Python/dtoa.c * Python/dtoa.c asks to frequently update it from "upstream" http://www.netlib.org/fp/dtoa.c * The upstream is also mentioned in the license: https://docs.python.org/dev/license.html#strtod-and-dtoa ... in pr

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-11 Thread Charalampos Stratakis
Change by Charalampos Stratakis : -- nosy: +mark.dickinson, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue36262] Coverity scan: Python/dtoa.c resource leak

2019-03-11 Thread Charalampos Stratakis
New submission from Charalampos Stratakis : Coverity report on dtoa.c. It was run on python2 but the same code resides on python3. Error: RESOURCE_LEAK (CWE-772): [#def89] Python-2.7.15/Python/dtoa.c:1846: alloc_fn: Storage is returned from allocation function "s2b". Python-2.7.15/Python/dtoa