[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Pablo Galindo Salgado added the comment: A lot of buildbots were failing for this test so a lot of them will become green after ff3d39faa8aa28308cc5eae6843eaac514da8fd8. -- ___ Python tracker __

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Pablo Galindo Salgado added the comment: New changeset ff3d39faa8aa28308cc5eae6843eaac514da8fd8 by Pablo Galindo (Serhiy Storchaka) in branch 'master': bpo-36109: Fix random test_descr failure. (GH-12044) https://github.com/python/cpython/commit/ff3d39faa8aa28308cc5eae6843eaac514da8fd8

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Pablo Galindo Salgado added the comment: Ok, actually this turns to be much easier: Sometimes __eq__ was also called twice but now as we use PyDict_GetItemWithError instead of PyDict_GetItem, if the extra __eq__ happens as a consequence of a dict lookup the error is ignored so that was the r

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Pablo Galindo Salgado added the comment: Although 12044 fixes the problem, something a bit more fundamental may have changed. I have spent time investigating why this is happening and the problem is that in the line: self.assertEqual(c.attr, 1) Evil.__eq__ is invoked twice where before it

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Pablo Galindo Salgado added the comment: Although PR12004 fixes the problem, something a bit more fundamental may have changed. I have spent time investigating why this is happening and the problem is that in the line: self.assertEqual(c.attr, 1) Evil.__eq__ is invoked twice where before i

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg336608 ___ Python tracker ___ ___ Python-bugs-list

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +12070 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Pablo Galindo Salgado added the comment: It seems that this is a race condition created as a consequence of: https://github.com/python/cpython/pull/2/files -- nosy: +serhiy.storchaka ___ Python tracker

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

Pablo Galindo Salgado added the comment: I can reproduce this locally. How has this not being spotted by the CI: ❯ ./python.exe -m test test_descr Run tests sequentially 0:00:00 load avg: 3.82 [1/1] test_descr test test_descr failed -- Traceback (most recent call last): File "/Users/pgalindo3

[issue36109] test_descr fails on AMD64 Windows8 3.x buildbots

New submission from Pablo Galindo Salgado : https://buildbot.python.org/all/#/builders/32/builds/2198 == ERROR: test_vicious_descriptor_nonsense (test.test_descr.ClassPropertiesAndMethods) -