[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11367 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11368 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

miss-islington added the comment: New changeset 47290e7642dd41d94437dd0e2c0f6bfceb0281b5 by Miss Islington (bot) in branch '3.7': bpo-35770: Fix off-by-1 error. (GH-11618) https://github.com/python/cpython/commit/47290e7642dd41d94437dd0e2c0f6bfceb0281b5 -- _

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by miss-islington : -- pull_requests: +11366, 11367 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by miss-islington : -- pull_requests: +11366 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by miss-islington : -- pull_requests: +11366, 11367, 11368 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Terry J. Reedy added the comment: New changeset 2cf1ddaff4c869780d9e796b21ef3e506f8ad321 by Terry Jan Reedy in branch 'master': bpo-35770: Fix off-by-1 error. (#11618) https://github.com/python/cpython/commit/2cf1ddaff4c869780d9e796b21ef3e506f8ad321 -- _

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11364 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11365 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: +11363, 11364, 11365 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: +11363, 11364 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: +11363 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11358 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11359 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11356 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11355 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11353 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- pull_requests: -11352 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

miss-islington added the comment: New changeset a01e23559fd77083a2c6c59692b70d7896e5f59a by Miss Islington (bot) in branch '3.7': bpo-35770: IDLE macosx deletes Options => Configure IDLE. (GH-11614) https://github.com/python/cpython/commit/a01e23559fd77083a2c6c59692b70d7896e5f59a --

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by miss-islington : -- pull_requests: +11357, 11358 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by miss-islington : -- pull_requests: +11357, 11358, 11359 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by miss-islington : -- pull_requests: +11357 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Terry J. Reedy added the comment: New changeset 39ed289a3511d2e9bf0950a9d5dc53c8194f61b9 by Terry Jan Reedy in branch 'master': bpo-35770: IDLE macosx deletes Options => Configure IDLE. (GH-11614) https://github.com/python/cpython/commit/39ed289a3511d2e9bf0950a9d5dc53c8194f61b9 --

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Cheryl Sabella : -- pull_requests: +11354, 11355, 11356 stage: needs patch -> patch review ___ Python tracker ___ ___ Pyth

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Cheryl Sabella : -- pull_requests: +11354 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list m

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Cheryl Sabella : -- pull_requests: +11354, 11355 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Cheryl Sabella added the comment: I'll submit a quick PR as a PoC. Tal emailed with additional ideas about menudefs, so I agree that another issue would probably be suitable for more discussion. I haven't looked at the extensions too closely yet, but the insert you're referring to is actua

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- keywords: +patch, patch, patch pull_requests: +11351, 11352, 11353 stage: needs patch -> patch review ___ Python tracker ___ _

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- keywords: +patch, patch pull_requests: +11351, 11352 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +11351 stage: needs patch -> patch review ___ Python tracker ___ ___ P

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Terry J. Reedy added the comment: Cheryl, that sort of change needs an issue for discussion before going very far. I am dubious that it will work (but you can try to show otherwise). 1. overrideRootMenu does an insertion that I don't think you can do with a dict. mainmenu.menudefs[0][1].in

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Karthikeyan Singaravelan added the comment: > Since it is my fix, I will write the PR. But first, please test part 2, > changing '0' to '0:1', just to make sure it works. Just tested it and it works fine with slice. Please find the respective diff and options menu displayed as below : git

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Cheryl Sabella added the comment: Terry, I've started working on a PR to change menudefs to a dictionary. Since dictionaries are in guaranteed order now, it would be easier to reference the menus by their name instead of an index number. -- ___

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Terry J. Reedy added the comment: Since it is my fix, I will write the PR. But first, please test part 2, changing '0' to '0:1', just to make sure it works. c1b added 'None,' (for separater bar) after the configdialog entry. When the configdialog entry is removed, the None should be also.

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Karthikeyan Singaravelan added the comment: Cheryl, feel free to submit a patch since I have less exposure to IDLE code. I can manually test the PR on my Mac and report back since this seems to be a Mac specific patch. It would be helpful if someone with access to other Mac OS versions can p

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Cheryl Sabella added the comment: Karthikeyan, Thanks for catching this! Did you want to submit the patch for it or did you want me to make the PR? We're still working on the tests for the menus, so this would just be a code change. -- ___ Pyth

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Karthikeyan Singaravelan added the comment: Thanks, I can confirm that your fix launches idlelib. Not working : del mainmenu.menudefs[-2][1][0] Working : del mainmenu.menudefs[-3][1][0] Options menu listing on master with the fix with "Show code context" disabled. - Show code context - Zoom

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

Terry J. Reedy added the comment: Thank you for the report. The error line "del mainmenu.menudefs[-2][1][0]" follows this comment. # Remove the 'Configure Idle' entry from the options menu, it is in the # application menu as 'Preferences' However, -2 is the Window menu, while Options is -

[issue35770] IDLE: python -m idlelib fails on master on Mac OS 10.10.4

New submission from Karthikeyan Singaravelan : I used to launch IDLE using from master using ./python.exe -m idlelib . It used to work but fails on master on Mac OS now. There seems to be some discussion about this on msg332672 after the commit c1b4b0f6160e1919394586f44b12538505fed300. Feel fr