[issue35611] open doesn't call IncrementalEncoder with final=True

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue35611] open doesn't call IncrementalEncoder with final=True

Martin Panter added the comment: FWIW this happens with the built-in IDNA codec, and Amaury gave a demonstration under . I don’t think the “TextIOWrapper.flush” method should use final=True, but “close” and “detach” probably should. -- no

[issue35611] open doesn't call IncrementalEncoder with final=True

Change by Serhiy Storchaka : -- assignee: -> lemburg nosy: +doerwalter, lemburg ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35611] open doesn't call IncrementalEncoder with final=True

New submission from David Haney : The implementation of open relies on a codecs' IncrementalEncoder, however it never calls `encode` with final=True. This appears to violate the documentation for IncrementalEncoder.encode which states that the last call to encode _must_ set final=True. The a