[issue35598] IDLE: Modernize config_key module

Terry J. Reedy added the comment: I moved PR 11427 to new issue #35675. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10852 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10851 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Cheryl Sabella added the comment: Terry, I just saw your note about waiting to split this into a Window and Frame class, which was after I had already gotten the PR ready. I've been mostly offline for the past few days, so I had been working on those changes locally with the intent of push

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10850, 10851 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10850, 10851, 10852 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10850 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Terry J. Reedy added the comment: This issue looks complete to me unless there is something simple not previously mentioned. Fixing cancel would be a separate issue. Separating window and frame needs separate discussion on a separate issue, and is not a priority now. Model popups are diffe

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- pull_requests: -10765 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- pull_requests: -10766 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

miss-islington added the comment: New changeset 74e46483773fa2ed03ed02f1b5e3fb0a4691535e by Miss Islington (bot) in branch '3.7': bpo-35598: IDLE - Globalize some config_key objects (GH-11392) https://github.com/python/cpython/commit/74e46483773fa2ed03ed02f1b5e3fb0a4691535e --

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10764, 10765, 10766 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35598] IDLE: Modernize config_key module

Terry J. Reedy added the comment: New changeset b4ea8bb080f63ef27682f3f9bbaa4d12a83030b1 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-35598: IDLE - Globalize some config_key objects (GH-11392) https://github.com/python/cpython/commit/b4ea8bb080f63ef27682f3f9bbaa4d12a83030b1 -

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10764, 10765 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10764 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10763 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Cheryl Sabella added the comment: PR11392 is the first refactor. It moves translate_key to the module level and also moves the definitions of the key tuples to the module level since they are used in more than one place (and they don't change). As a side note, I'll do the refactoring over s

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10762 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- Removed message: https://bugs.python.org/msg332776 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10761, 10762 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10761, 10762, 10763 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10761 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10722 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10723 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Cheryl Sabella added the comment: PR11377 is the first refactor. It moves translate_key to the module level and also moves the definitions of the key tuples to the module level since they are used in more than one place (and they don't change). As a side note, I'll do the refactoring over s

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10721, 10722, 10723 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10721 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10721, 10722 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35598] IDLE: Modernize config_key module

miss-islington added the comment: New changeset d2694d47682b84dafef1c172ede7ad16d3b8bbd8 by Miss Islington (bot) in branch '3.7': bpo-35598: IDLE: Switch config_key dialog to ttk widgets (GH-11365) https://github.com/python/cpython/commit/d2694d47682b84dafef1c172ede7ad16d3b8bbd8 --

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10707 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Terry J. Reedy added the comment: New changeset 4bd79c38efe3cc0a3c724605cf9474e2d1b6b6e2 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-35598: IDLE: Switch config_key dialog to ttk widgets (GH-11365) https://github.com/python/cpython/commit/4bd79c38efe3cc0a3c724605cf9474e2d1b6b6e

[issue35598] IDLE: Modernize config_key module

Cheryl Sabella added the comment: PR11365 revises the imports and switches to ttk widgets. -- ___ Python tracker ___ ___ Python-bug

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10697 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10696 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10695 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10695, 10696 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10695, 10696, 10697 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- pull_requests: -10686 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- pull_requests: -10687 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

miss-islington added the comment: New changeset 34aadec448f373b95653318e91f6f959354ffa89 by Miss Islington (bot) in branch '3.7': bpo-35598: IDLE: Increase test coverage for config_key.py (GH-11360) https://github.com/python/cpython/commit/34aadec448f373b95653318e91f6f959354ffa89 --

[issue35598] IDLE: Modernize config_key module

Terry J. Reedy added the comment: New changeset b0a6196ffd58ff91462191f426706897dc920eee by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-35598: IDLE: Increase test coverage for config_key.py (#11360) https://github.com/python/cpython/commit/b0a6196ffd58ff91462191f426706897dc920eee

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10685, 10686, 10687 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10685 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10685, 10686 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35598] IDLE: Modernize config_key module

Cheryl Sabella added the comment: PR11360 adds tests to increase coverage. There isn't any refactor (moving translate_key) as part of this. I also didn't add any GUI-related tests against the buttons, entry, or listbox, except for the cancel key (in case that helps with the new bug reporte

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10681 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: -10680 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10679, 10680 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10679, 10680, 10681 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- pull_requests: +10679 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- pull_requests: -10610 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

miss-islington added the comment: New changeset 4c7f34f73d2d16303798fc4a7043e641cee58e51 by Miss Islington (bot) in branch '3.7': bpo-35598: IDLE: Update config_key.py with PEP8 names (GH-11330) https://github.com/python/cpython/commit/4c7f34f73d2d16303798fc4a7043e641cee58e51 -- nos

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- pull_requests: -10611 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10609, 10610, 10611 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10609 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35598] IDLE: Modernize config_key module

Terry J. Reedy added the comment: New changeset 55698cc39549523cafc13cc8dd47960d8f73a59f by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-35598: IDLE: Update config_key.py with PEP8 names (GH-11330) https://github.com/python/cpython/commit/55698cc39549523cafc13cc8dd47960d8f73a59f

[issue35598] IDLE: Modernize config_key module

Change by miss-islington : -- pull_requests: +10609, 10610 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list maili

[issue35598] IDLE: Modernize config_key module

Terry J. Reedy added the comment: If you submit further PRs for this issue, the blurb will need to be changed as blurbs are for issues, not PRs. -- ___ Python tracker ___ ___

[issue35598] IDLE: Modernize config_key module

Terry J. Reedy added the comment: I am going to merge on the presumption that you will follow through at least with more tests. Currently missing other than mac-code, according to coverage output: switch from 'advanced to basic and calls to final_key_selected, build_key_string, get_modifier

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- pull_requests: -10599 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Change by Terry J. Reedy : -- pull_requests: -10598 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35598] IDLE: Modernize config_key module

Cheryl Sabella added the comment: PR11330 is for the PEP8 naming conventions. -- stage: patch review -> ___ Python tracker ___ ___

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- keywords: +patch, patch, patch pull_requests: +10597, 10598, 10599 stage: -> patch review ___ Python tracker ___

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- keywords: +patch, patch pull_requests: +10597, 10598 stage: -> patch review ___ Python tracker ___ __

[issue35598] IDLE: Modernize config_key module

Change by Cheryl Sabella : -- keywords: +patch pull_requests: +10597 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue35598] IDLE: Modernize config_key module

New submission from Cheryl Sabella : * Apply PEP8 naming convention. * Add additional tests to get coverage (close?) to 100%. * Update to more meaningful names. * Switch to ttk widgets and revise imports. * Split toplevel class into a window class and frame class(es). -- assignee: terry