[issue35482] can't open python368rc1.chm and python372rc1.chm

Ned Deily added the comment: New changeset 4db9a3fffa232e88fcc2ad3b5ce35e9f8657bbe5 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-35482: Fixes HTML escaping in CHM index and build location of NEWS file (GH-11224) https://github.com/python/cpython/commit/4db9a3fffa232e88fcc2ad3b5ce

[issue35482] can't open python368rc1.chm and python372rc1.chm

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue35482] can't open python368rc1.chm and python372rc1.chm

Ned Deily added the comment: New changeset 789b0ee023f14385a2fd635272768c3b55a99773 by Ned Deily (Steve Dower) in branch '3.6': bpo-35482: Fixes HTML escaping in CHM index and build location of NEWS file (GH-11224) (GH-11251) https://github.com/python/cpython/commit/789b0ee023f14385a2fd63527

[issue35482] can't open python368rc1.chm and python372rc1.chm

Steve Dower added the comment: The 3.6 PR is blocked from merging, so looking to Ned to resolve. -- ___ Python tracker ___ ___ Pyth

[issue35482] can't open python368rc1.chm and python372rc1.chm

Change by Steve Dower : -- pull_requests: +10501 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue35482] can't open python368rc1.chm and python372rc1.chm

miss-islington added the comment: New changeset aae2e85af772a409bf8904bddc17efe9bf809174 by Miss Islington (bot) in branch '3.7': bpo-35482: Fixes HTML escaping in CHM index and build location of NEWS file (GH-11224) https://github.com/python/cpython/commit/aae2e85af772a409bf8904bddc17efe9bf

[issue35482] can't open python368rc1.chm and python372rc1.chm

Change by miss-islington : -- pull_requests: +10499 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35482] can't open python368rc1.chm and python372rc1.chm

Ma Lin added the comment: ' comes from html.escape(s, quote=True) https://github.com/python/cpython/blob/4a9ee26750aa8cb37b5072b2bb4dd328819febb4/Lib/html/__init__.py#L24 Of course, it's not a bug. It would be better to patch in Sphinx, I will do it at some point. --

[issue35482] can't open python368rc1.chm and python372rc1.chm

Change by Steve Dower : -- pull_requests: +10459 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue35482] can't open python368rc1.chm and python372rc1.chm

Steve Dower added the comment: I've got an alternate PR to do the fixup in an extension, as well as fixing two other minor build problems for docs (on Windows). -- ___ Python tracker ___

[issue35482] can't open python368rc1.chm and python372rc1.chm

Serhiy Storchaka added the comment: I think this is a Sphinx bug. It should work around limitations of the CHM compiler. -- ___ Python tracker ___ ___

[issue35482] can't open python368rc1.chm and python372rc1.chm

Steve Dower added the comment: It looks like generally the ' entity does not work in the CHM index - there should be b' and u' entries as well, but they show up as b and u (whereas b" and u" are fine). Substituting ' seems to work fine, but I had to do that manually in the hhk file and then

[issue35482] can't open python368rc1.chm and python372rc1.chm

Ma Lin added the comment: amazing, you did find it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue35482] can't open python368rc1.chm and python372rc1.chm

Serhiy Storchaka added the comment: The breakage was caused by the index entry for ''' (triple single quote). After removing it a correct CHM file is created. -- ___ Python tracker _

[issue35482] can't open python368rc1.chm and python372rc1.chm

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +10443 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue35482] can't open python368rc1.chm and python372rc1.chm

Ma Lin added the comment: > I guess the next step is to try taking out those new index entries to figure > out which one causes the problem. Very big amount of work..., I would suggest to revert them. chm is a successful product, but it out of support, and no replacement yet, it's regrettabl

[issue35482] can't open python368rc1.chm and python372rc1.chm

Steve Dower added the comment: I did a quick look and couldn't find anything obvious in logs while building, so I guess the next step is to try taking out those new index entries to figure out which one causes the problem. (Adding Serhiy for awareness, not necessarily trying to nominate him

[issue35482] can't open python368rc1.chm and python372rc1.chm

Ma Lin added the comment: These first bad commits come from issue35054 -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35482] can't open python368rc1.chm and python372rc1.chm

Ma Lin added the comment: python368rc1.chm has the same problem. I did a git bisect. On 3.6 branch, e825b4e1a9bbe1d4c561f4cbbe6857653ef13a15 is the first bad commit On 3.7 branch, 9a75b8470a2e0de5406edcabba140f023c99c6a9 is the first bad commit -- title: python372rc1.chm is ill -> can