[issue35416] Fix potential resource warnings in distutils

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue35416] Fix potential resource warnings in distutils

Inada Naoki added the comment: New changeset 58721a903074d28151d008d8990c98fc31d1e798 by Inada Naoki (Mickaël Schoentgen) in branch 'master': bpo-35416: fix potential resource warnings in distutils (GH-10918) https://github.com/python/cpython/commit/58721a903074d28151d008d8990c98fc31d1e798 -

[issue35416] Fix potential resource warnings in distutils

Mickaël Schoentgen added the comment: OK then I updated the PR to only update code that would really leak resources. -- ___ Python tracker ___ _

[issue35416] Fix potential resource warnings in distutils

Éric Araujo added the comment: I think the places that already use try/finally: close are correct. We try to minimize churn in distutils; changing to with is nice but does not fix errors or warning in these cases. The changes for the few spots that don’t use finally: close are welcome though!

[issue35416] Fix potential resource warnings in distutils

Mickaël Schoentgen added the comment: I saw it but it is quite old and targetting 3.5. I opended this issue to target only distutils, easier to eventually backport than a big patch on a lot of files. -- ___ Python tracker

[issue35416] Fix potential resource warnings in distutils

Karthikeyan Singaravelan added the comment: There is a similar open issue issue22831 with patches for distutils and Tools. -- nosy: +serhiy.storchaka, xtreak ___ Python tracker __

[issue35416] Fix potential resource warnings in distutils

Change by Mickaël Schoentgen : -- keywords: +patch pull_requests: +10157 stage: -> patch review ___ Python tracker ___ ___ Python-bu

[issue35416] Fix potential resource warnings in distutils

New submission from Mickaël Schoentgen : I am looking to clean-up potential ResourceWarnings in distutils. The patch will provide 2 changes: - ensure file descriptor are always closed when it is not the case - and uniformization of the "with open(...)" use -- components: Distuti