[issue35328] Set a environment variable for venv prompt

Change by Brett Cannon : -- resolution: fixed -> status: closed -> open versions: +Python 3.10 -Python 3.9 ___ Python tracker ___ _

[issue35328] Set a environment variable for venv prompt

Change by Mathias Fredriksson : -- pull_requests: +21368 pull_request: https://github.com/python/cpython/pull/22324 ___ Python tracker ___ _

[issue35328] Set a environment variable for venv prompt

Mathias Fredriksson added the comment: I believe GH-21587 does not fully address this issue because VIRTUAL_ENV_PROMPT is being conditionally set only if VIRTUAL_ENV_DISABLE_PROMPT is unset. Shell prompts must set VIRTUAL_ENV_DISABLE_PROMPT to non-empty to prevent venv from hijacking PS1. I'

[issue35328] Set a environment variable for venv prompt

Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue35328] Set a environment variable for venv prompt

Vinay Sajip added the comment: New changeset c82dda1e08c4b74ca24f88d6a549d93108c319cf by Zackery Spytz in branch 'master': bpo-35328: Set VIRTUAL_ENV_PROMPT at venv activation (GH-21587) https://github.com/python/cpython/commit/c82dda1e08c4b74ca24f88d6a549d93108c319cf -- __

[issue35328] Set a environment variable for venv prompt

Change by Zackery Spytz : -- nosy: +ZackerySpytz nosy_count: 6.0 -> 7.0 pull_requests: +20727 pull_request: https://github.com/python/cpython/pull/21587 ___ Python tracker ___

[issue35328] Set a environment variable for venv prompt

Change by Vinay Sajip : -- versions: +Python 3.9 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35328] Set a environment variable for venv prompt

Brett Cannon added the comment: You can open a new PR with co-author or basing off of their fork if it's still around. -- ___ Python tracker ___ _

[issue35328] Set a environment variable for venv prompt

Lysandros Nikolaou added the comment: @brettcannon, yeah I saw that, but there hasn't been any progress since November. I'm still interested in this though. What would the correct workflow be? Pushing commits to the same PR or opening a new one with a co-author? -- _

[issue35328] Set a environment variable for venv prompt

Brett Cannon added the comment: @lys.nikolaou it looks like there was an initial PR, but it only updated things for Bash and not for all the other shells that we support for virtual environments. -- nosy: +brett.cannon ___ Python tracker

[issue35328] Set a environment variable for venv prompt

Lysandros Nikolaou added the comment: Is anybody still working on this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35328] Set a environment variable for venv prompt

Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue35328] Set a environment variable for venv prompt

Karthikeyan Singaravelan added the comment: issue34439 seems like a similar proposal. I am adding @vinay.sajip. Since this seems like a new feature I have removed 3.7 from the version list. -- components: +Library (Lib) nosy: +vinay.sajip, xtreak type: -> enhancement versions: -Pyth

[issue35328] Set a environment variable for venv prompt

Baptiste Darthenay added the comment: How the venv prompt name would be displayed in a project like Powerline? Or in VS Code? https://i.ibb.co/JHYrnk2/Screenshot-from-2018-11-27-19-41-47.png Or in my custom prompt? https://gist.github.com/batisteo/c5c9bd87a344cdbfb7a6401648c118a2#file-batist

[issue35328] Set a environment variable for venv prompt

Anthony Sottile added the comment: The current prompt works fine for me on zsh -- what's the bug here? zsh $ virtualenv venv --prompt '(wat)' Using real prefix '/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7' New python executable in /private/tmp/venv/bin/python3.7 Al

[issue35328] Set a environment variable for venv prompt

Change by Baptiste Darthenay : -- keywords: +patch pull_requests: +9992 stage: -> patch review ___ Python tracker ___ ___ Python-bu

[issue35328] Set a environment variable for venv prompt

New submission from Baptiste Darthenay : When creating a new virtual env with `python3 -m venv .venv --prompt env`, the prompt information is only used to set a temporary PS1. This information is lost when using custom prompt, for example with ZSH. I propose to set VIRTUAL_ENV_PROMPT=__VENV_P