[issue35168] shlex punctuation_chars inconsistency

Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue35168] shlex punctuation_chars inconsistency

Vinay Sajip added the comment: New changeset 3b92ddb7612fd8fe2be95ff3d8022ed18335b13f by Vinay Sajip in branch '3.8': [3.8] bpo-35168: Make shlex.punctuation_chars read-only (GH-11631) (GH-15927) https://github.com/python/cpython/commit/3b92ddb7612fd8fe2be95ff3d8022ed18335b13f -- _

[issue35168] shlex punctuation_chars inconsistency

Vinay Sajip added the comment: New changeset aca878ecf18b9e915e9b551f095a550b5c6e9bc5 by Vinay Sajip in branch '3.7': [3.7] bpo-35168: Make shlex.punctuation_chars read-only (GH-11631) (GH-15926) https://github.com/python/cpython/commit/aca878ecf18b9e915e9b551f095a550b5c6e9bc5 -- _

[issue35168] shlex punctuation_chars inconsistency

Change by Vinay Sajip : -- pull_requests: +15567 pull_request: https://github.com/python/cpython/pull/15927 ___ Python tracker ___ _

[issue35168] shlex punctuation_chars inconsistency

Change by Vinay Sajip : -- pull_requests: +15566 pull_request: https://github.com/python/cpython/pull/15926 ___ Python tracker ___ _

[issue35168] shlex punctuation_chars inconsistency

Vinay Sajip added the comment: New changeset 972cf5c06a5ba16ad243a442dbb9c15307fbed95 by Vinay Sajip (Alex) in branch 'master': bpo-35168: Make shlex.punctuation_chars read-only (#11631) https://github.com/python/cpython/commit/972cf5c06a5ba16ad243a442dbb9c15307fbed95 -- __

[issue35168] shlex punctuation_chars inconsistency

Change by Vinay Sajip : -- pull_requests: -11403 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue35168] shlex punctuation_chars inconsistency

Change by Vinay Sajip : -- pull_requests: -11401 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue35168] shlex punctuation_chars inconsistency

Change by Vinay Sajip : -- pull_requests: -11402 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue35168] shlex punctuation_chars inconsistency

Change by Roundup Robot : -- keywords: +patch, patch, patch, patch pull_requests: +11400, 11401, 11402, 11403 stage: needs patch -> patch review ___ Python tracker ___

[issue35168] shlex punctuation_chars inconsistency

Change by Roundup Robot : -- keywords: +patch, patch, patch pull_requests: +11400, 11401, 11402 stage: needs patch -> patch review ___ Python tracker ___ __

[issue35168] shlex punctuation_chars inconsistency

Change by Roundup Robot : -- keywords: +patch, patch pull_requests: +11400, 11401 stage: needs patch -> patch review ___ Python tracker ___

[issue35168] shlex punctuation_chars inconsistency

Change by Roundup Robot : -- keywords: +patch pull_requests: +11400 stage: needs patch -> patch review ___ Python tracker ___ ___ Py

[issue35168] shlex punctuation_chars inconsistency

Change by Cheryl Sabella : -- assignee: -> docs@python components: +Documentation -Library (Lib) keywords: +easy nosy: +docs@python stage: -> needs patch versions: -Python 3.6 ___ Python tracker __

[issue35168] shlex punctuation_chars inconsistency

Vinay Sajip added the comment: > a better run time error message which clarifies that shlex.punctuation_chars > is read-only That it can be set only via the __init__(), yes. -- ___ Python tracker _

[issue35168] shlex punctuation_chars inconsistency

tphh added the comment: So a documentation update and a better run time error message which clarifies that shlex.punctuation_chars is read-only? -- ___ Python tracker ___ ___

[issue35168] shlex punctuation_chars inconsistency

Raymond Hettinger added the comment: It makes sense to me that information used in an expensive one-time setup should be specified in advance where other parameters that are more easily changed are specified downstream. The API reflects the a sensible way to use the tool. Making it to easy

[issue35168] shlex punctuation_chars inconsistency

Vinay Sajip added the comment: I agree that it's inconsistent, but quite a bit of setting up is done when punctuation_chars is provided, as per the link in msg329312. One could convert the attribute to a property and have a setter that does the equivalent set up, but some of the setup is one

[issue35168] shlex punctuation_chars inconsistency

Karthikeyan Singaravelan added the comment: Thanks for the report. The code was added with c1f974c944a3e73cbc9102356d8700a190dcafb3 and self._pushback_chars is declared only when punctuation_chars is passed to shlex.shlex in the constructor as you have mentioned in https://github.com/python

[issue35168] shlex punctuation_chars inconsistency

New submission from tphh : The newly added shlex.punctuation_chars is special compared to the other public instance variables: It can ONLY be used when constructing a shlex instance, unlike other public instance variables, such as commenters, which can ONLY be set later. >>> s = shlex.shlex(