[issue35166] BUILD_MAP_UNPACK doesn't function as expected for dict subclasses

2021-12-30 Thread Irit Katriel
Irit Katriel added the comment: BUILD_MAP_UNPACK and BUILD_MAP_UNPACK_WITH_CALL have been removed. -- nosy: +iritkatriel ___ Python tracker ___ ___

[issue35166] BUILD_MAP_UNPACK doesn't function as expected for dict subclasses

2018-11-04 Thread Steven D'Aprano
Steven D'Aprano added the comment: How weird... after restarting the interpreter, I can't reproduce that TypeError. I get the AssertionError Serhiy showed. -- ___ Python tracker

[issue35166] BUILD_MAP_UNPACK doesn't function as expected for dict subclasses

2018-11-04 Thread Steven D'Aprano
Steven D'Aprano added the comment: You say it doesn't work as expected, but you don't say what you expect or why. (Don't make me guess what you mean -- explicit is better than implicit.) When I try your subclass in 3.6, I get an unexpected TypeError: py> class Dict(dict): ... def keys(se

[issue35166] BUILD_MAP_UNPACK doesn't function as expected for dict subclasses

2018-11-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Traceback (most recent call last): File "", line 1, in File "", line 2, in keys AssertionError This works as expected to me. -- nosy: +serhiy.storchaka ___ Python tracker

[issue35166] BUILD_MAP_UNPACK doesn't function as expected for dict subclasses

2018-11-04 Thread Dan Snider
New submission from Dan Snider : >>> class Dict(dict): def keys(self): assert 0 def update(*args, **kwds): assert 0 def __getitem__(self, key): assert 0 def __iter__(self): assert 0 >>> {**Dict(a=1)} {'a': 1} The opcode uses PyDict_Update, whic