[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Change by Eryk Sun : -- versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list maili

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Eryk Sun added the comment: It seems to me that if `path == name`, then resetperms(path) and possibly a recursive call are only needed on the first call. In subsequent calls, if `path == name`, then we know that resetperms(path) was already called, so it shouldn't handle PermissionError. If

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Vidar Fauske added the comment: A somewhat easy repro: Create the temporary directory, add a subdir (not sure if subdir truly necessary at this point), use `os.chdir()` to set the cwd to that subdir. Clean up the temp dir. The cwd should prevent the deletion because it will be "in use". --

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Serhiy Storchaka added the comment: Thank you Vidar! I wasn't sure about Windows, but was not able to reproduce possible failures. Your report gives a clue. -- ___ Python tracker ___

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Vidar Fauske added the comment: On Python 3.8.5 on Windows using the code from the above patch I recently got a stack overflow: Thread 0x2054 (most recent call first): File "...\lib\concurrent\futures\thread.py", line 78 in _worker File "...\lib\threading.py", line 870 in run File "

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Serhiy Storchaka added the comment: New changeset e9b51c0ad81da1da11ae65840ac8b50a8521373c by Serhiy Storchaka in branch 'master': bpo-26660, bpo-35144: Fix permission errors in TemporaryDirectory cleanup. (GH-10320) https://github.com/python/cpython/commit/e9b51c0ad81da1da11ae65840ac8b50a85

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +9622 stage: -> patch review ___ Python tracker ___ ___ Python-bugs

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Serhiy Storchaka added the comment: I am working on this. Left to test on Windows and analyze possible security issues. -- ___ Python tracker ___

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

lilydjwg added the comment: Yes issue26660 is similar but not the same. On Windows it seems a read-only file cannot be deleted while on Linux a file resident in a non-searchable directory cannot be deleted. An onerror for TemporaryDirectory will work. Also I'd like to add an optional dir_fd

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

Change by Terry J. Reedy : -- title: TemporaryDirectory can't be cleaned up if there are unsearchable directories -> TemporaryDirectory clean-up fails with unsearchable directories ___ Python tracker ___