[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread miss-islington
miss-islington added the comment: New changeset e389de8e3e897fa5ba4f71b0f711355fb7158049 by Miss Islington (bot) in branch '2.7': bpo-35079: Revise difflib.SequenceManager.get_matching_blocks doc (GH-10144) https://github.com/python/cpython/commit/e389de8e3e897fa5ba4f71b0f711355fb7158049 --

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread miss-islington
miss-islington added the comment: New changeset 5282125650a70811f0d64ab231e2a6c8ac20c96b by Miss Islington (bot) in branch '3.6': bpo-35079: Revise difflib.SequenceManager.get_matching_blocks doc (GH-10144) https://github.com/python/cpython/commit/5282125650a70811f0d64ab231e2a6c8ac20c96b --

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread miss-islington
miss-islington added the comment: New changeset cb920c1442bf3b0899fee51915b4bf6614f2c1d7 by Miss Islington (bot) in branch '3.7': bpo-35079: Revise difflib.SequenceManager.get_matching_blocks doc (GH-10144) https://github.com/python/cpython/commit/cb920c1442bf3b0899fee51915b4bf6614f2c1d7 --

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread miss-islington
Change by miss-islington : -- pull_requests: +9474 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset d9bff4e81b8ca36fe6c4e90c0b9cf02bc020e713 by Terry Jan Reedy in branch 'master': bpo-35079: Revise difflib.SequenceManager.get_matching_blocks doc (GH-10144) https://github.com/python/cpython/commit/d9bff4e81b8ca36fe6c4e90c0b9cf02bc020e713 ---

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread miss-islington
Change by miss-islington : -- pull_requests: +9473 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread miss-islington
Change by miss-islington : -- pull_requests: +9472 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: Tim, I share your concern about bloating docs, but think this one word worthwhile. I suspect that people are conditioned to accept 'non-overlapping' because that is ofter (usually?) the default for linear searches and regex matching. -- stage: patc

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +9471 stage: needs patch -> patch review ___ Python tracker ___ ___ Py

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Tim Peters
Tim Peters added the comment: I don't object to spelling it out more, and your (Terry's) suggestions are fine. On the other hand, this module has been around for a lng time now, and this is the first instance I've seen of someone surprised that it doesn't produce overlapping matches - i

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: We can assume that "substring 'CA'" was meant to be "substring 'AC'", but as explained, missing 'AC' is not a bug. (Tim wrote the module.) I read the doc, and 'non-overlapping' is implied in the SequenceMatcher entry at the top of the file. "The idea is to

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Tim Peters
Tim Peters added the comment: Sorry, I find this too hard to follow. At the end: > ['TA', 'CA'] # Missing the substring 'CA' the comment claims it's missing 'CA', while the output plainly shows it's _not_ missing 'CA'. If your complaint is that's missing 'AC', yes, it is. It's not intende

[issue35079] difflib.SequenceMatcher.get_matching_blocks omits common strings

2018-10-26 Thread Springem Springsbee
New submission from Springem Springsbee : Hello, I'm using difflib's SequenceMatcher to locate common substrings. It seems like the matcher is missing a common substrings. I'm guessing this is a rather low-level issue in difflib. The autojunk parameter has no effect for obvious reasons. Alter