[issue34980] KillPython target doesn't detect 64-bit processes

Jeremy Kloth added the comment: The changed succeeded in killing the actively stuck process, so I say its all good! Thanks for the merge. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue34980] KillPython target doesn't detect 64-bit processes

Steve Dower added the comment: Jeremy - feel free to close this when you're happy with the buildbot results. -- stage: patch review -> commit review ___ Python tracker ___ ___

[issue34980] KillPython target doesn't detect 64-bit processes

miss-islington added the comment: New changeset 69d0372fc9c5a600ecdfb7dd80f852b26c6ed087 by Miss Islington (bot) in branch '3.6': bpo-34980: P/Invoke QueryFullProcessImageName to get process names (GH-9901) https://github.com/python/cpython/commit/69d0372fc9c5a600ecdfb7dd80f852b26c6ed087 --

[issue34980] KillPython target doesn't detect 64-bit processes

miss-islington added the comment: New changeset 7a253dcd97fa669b8615476b287ef4dd0a935014 by Miss Islington (bot) in branch '3.7': bpo-34980: P/Invoke QueryFullProcessImageName to get process names (GH-9901) https://github.com/python/cpython/commit/7a253dcd97fa669b8615476b287ef4dd0a935014 --

[issue34980] KillPython target doesn't detect 64-bit processes

Change by miss-islington : -- pull_requests: +9392 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34980] KillPython target doesn't detect 64-bit processes

Change by miss-islington : -- pull_requests: +9393 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34980] KillPython target doesn't detect 64-bit processes

Steve Dower added the comment: New changeset fa5329424f4206630c34f75629fa78738db647f0 by Steve Dower (Jeremy Kloth) in branch 'master': bpo-34980: P/Invoke QueryFullProcessImageName to get process names (GH-9901) https://github.com/python/cpython/commit/fa5329424f4206630c34f75629fa78738db647f

[issue34980] KillPython target doesn't detect 64-bit processes

Steve Dower added the comment: Sorry for missing the PR. One little tweak for consistency, but otherwise it looks fine. -- ___ Python tracker ___

[issue34980] KillPython target doesn't detect 64-bit processes

Jeremy Kloth added the comment: It seems my buildbot has a stuck process again. The "sticking" occurred in this case due to test_concurrent_futures being hung (for over 38hrs! which is a different issue) and a DSL link reset at the same time. So now, all builds on the master branch fail bec

[issue34980] KillPython target doesn't detect 64-bit processes

Change by Jeremy Kloth : -- keywords: +patch pull_requests: +9263 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue34980] KillPython target doesn't detect 64-bit processes

Eryk Sun added the comment: > there shouldn't be any problem with 33-bit/64-bit here. Windows > doesn't separate processes like that. Accessing the MainModule property of a .NET Process object raises an exception if the current process is 32-bit and the process is 64-bit [1]. This is because

[issue34980] KillPython target doesn't detect 64-bit processes

Jeremy Kloth added the comment: Alternatively, to test for yourself: 1) build a 64-bit python: > build -e -d -k -v -p x64 2) start the newly built interpreter: > amd64\python_d.exe 3) in a different command prompt (using dummy target to just do the KillPython) > build -e -d -k -v

[issue34980] KillPython target doesn't detect 64-bit processes

Jeremy Kloth added the comment: My testing shows differently: D:\Public\Devel\cpython\master\PCbuild>set MSBUILD="C:\Program Files (x86)\MSBuild\14.0\Bin\amd64\MSBuild.exe" D:\Public\Devel\cpython\master\PCbuild>build -k -v -t foo Using py -3.6 (found 3.6 with py.exe) Fetching external libra

[issue34980] KillPython target doesn't detect 64-bit processes

Steve Dower added the comment: I haven't looked at the logs, but there shouldn't be any problem with 33-bit/64-bit here. Windows doesn't separate processes like that. Perhaps we have builds with slightly different names (casing?) that are failing the comparison? --

[issue34980] KillPython target doesn't detect 64-bit processes

New submission from Jeremy Kloth : Since the KillPython target has been rewritten as an InlineTask, it can no longer detect 64-bit processes due to MSBuild being 32-bit. This leads to stuck buildbot runs: https://buildbot.python.org/all/#/builders/17/builds/348 A few solutions that I can th