[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-26 Thread Mark Dickinson
Mark Dickinson <[EMAIL PROTECTED]> added the comment: Fixed, r65257. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-26 Thread Facundo Batista
Facundo Batista <[EMAIL PROTECTED]> added the comment: The patch looks great, feel free to apply it and commit. For the record: the name issue that Mark talked about is not in this last change, it was before, and we handled it the way we now decide (hey, at least we're coherent with ourselves, ;

[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-26 Thread Mark Dickinson
Changes by Mark Dickinson <[EMAIL PROTECTED]>: -- keywords: +patch Added file: http://bugs.python.org/file10987/issue3449.patch ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-26 Thread Mark Dickinson
Mark Dickinson <[EMAIL PROTECTED]> added the comment: Looks like the changes needed here are even more minor than I thought. The decimal module already does the right thing with respect to the new specification and the new tests. So all that needs doing is to replace the old tests with the new

[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-25 Thread Raymond Hettinger
Raymond Hettinger <[EMAIL PROTECTED]> added the comment: P.S. I also agree with Mark that the 1.68 update should be treated as a bugfix and go into the next beta, preferably as soon as possible. Facundo and I should both agree to give it a quick and thorough review so that the beta is as soli

[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-25 Thread Raymond Hettinger
Raymond Hettinger <[EMAIL PROTECTED]> added the comment: -1 on renaming. I concur with Mark that we are under no obligation to match the names used in the spec -- only the functionality matters -- also we're already got a history of at least slightly different names. I also see no reason to

[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-25 Thread Facundo Batista
Facundo Batista <[EMAIL PROTECTED]> added the comment: -0 to rename it, specially considering that we had a reduce builtin in our history... better to not confuse it. But we'd need to convert the name in the tests... ___ Python tracker <[EMAIL PROTECTED]>

[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-25 Thread Mark Dickinson
Mark Dickinson <[EMAIL PROTECTED]> added the comment: One change from v1.66 to v1.68 of the spec: """The normalize operation has been renamed reduce to avoid confusion with normal numbers.""" The decimal module is not under any obligation to use the same names as in the IBM specification, so

[issue3449] Update decimal module to version 1.68 of the IBM specification

2008-07-25 Thread Mark Dickinson
New submission from Mark Dickinson <[EMAIL PROTECTED]>: The IBM General Decimal Arithmetic Specification, on which the decimal module is based, has recently been updated to version 1.68; the testcases from IBM have also been updated. The comments in the decimal module clearly state that the d