[issue3437] robotparser.py missing one line

Skip Montanaro <[EMAIL PROTECTED]> added the comment: committed as r 65255. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3437] robotparser.py missing one line

Skip Montanaro <[EMAIL PROTECTED]> added the comment: Attached is a patch against 2.6 which adds the missing line (state = 2), a comment describing the three states the parser can be in and expands the test cases to cover this change (fail without it, pass with it). In the process I snagged s

[issue3437] robotparser.py missing one line

Changes by Skip Montanaro <[EMAIL PROTECTED]>: ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue3437] robotparser.py missing one line

Skip Montanaro <[EMAIL PROTECTED]> added the comment: *sigh* there are no test cases in the current code with Allow: lines in test_robotparser.py. -- priority: -> normal versions: +Python 2.6 ___ Python tracker <[EMAIL PROTECTED]>

[issue3437] robotparser.py missing one line

Skip Montanaro <[EMAIL PROTECTED]> added the comment: *sigh* there are no test cases with Allow: lines in test_robotparser.py. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3437] robotparser.py missing one line

Skip Montanaro <[EMAIL PROTECTED]> added the comment: Perhaps more important than a test case, can you explain what states 0, 1 and 2 are (maybe give them some symbolic names I can at least put in a comment)? This is not my code. Though I wrote the first version of the robotparser module and

[issue3437] robotparser.py missing one line

Skip Montanaro <[EMAIL PROTECTED]> added the comment: Do you have a concrete robots.txt file I can use in a test case? ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3437] robotparser.py missing one line

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- assignee: -> skip.montanaro nosy: +skip.montanaro ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3437] robotparser.py missing one line

New submission from mARK <[EMAIL PROTECTED]>: RobotFileParser.parse() contains the lines elif line[0] == "disallow": if state != 0: entry.rulelines.append(RuleLine(line[1], False)) state = 2 elif