[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Tal Einat added the comment: Many thanks for the report and follow through, Vlad! Thank you too, Kevin, for your help in resolving this. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

miss-islington added the comment: New changeset 8c4a0059accb5cb33e90ec5b2f3e9dc08e2f3048 by Miss Islington (bot) in branch '3.6': bpo-34120: fix text viewer to call grab_release() only when needed (GH-8616) https://github.com/python/cpython/commit/8c4a0059accb5cb33e90ec5b2f3e9dc08e2f3048 --

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

miss-islington added the comment: New changeset 60586de02de074a33c015e5a013d85d0b17e7e61 by Miss Islington (bot) in branch '3.7': bpo-34120: fix text viewer to call grab_release() only when needed (GH-8616) https://github.com/python/cpython/commit/60586de02de074a33c015e5a013d85d0b17e7e61 --

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by miss-islington : -- pull_requests: +8123 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by miss-islington : -- pull_requests: +8124 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Tal Einat added the comment: New changeset dd74369cb7b230b07ac3a031563406c8f2aae17f by Tal Einat in branch 'master': bpo-34120: fix text viewer to call grab_release() only when needed (GH-8616) https://github.com/python/cpython/commit/dd74369cb7b230b07ac3a031563406c8f2aae17f -- ___

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Tal Einat added the comment: New changeset 894940b1099677c1ca0aa527dbb935e47d3d591a by Tal Einat in branch '2.7': [2.7] bpo-34120: fix IDLE freezing after closing dialogs (GH-8603) https://github.com/python/cpython/commit/894940b1099677c1ca0aa527dbb935e47d3d591a --

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

miss-islington added the comment: New changeset 9fcfb7b010bd41d4ebaeed372df92b6962253fed by Miss Islington (bot) in branch '3.6': bpo-34120: fix IDLE freezing after closing dialogs (GH-8603) https://github.com/python/cpython/commit/9fcfb7b010bd41d4ebaeed372df92b6962253fed -- __

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by Tal Einat : -- pull_requests: +8122 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by miss-islington : -- pull_requests: +8121 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

miss-islington added the comment: New changeset d9fc795487f74531ea43760469cc215858d0d908 by Miss Islington (bot) in branch '3.7': bpo-34120: fix IDLE freezing after closing dialogs (GH-8603) https://github.com/python/cpython/commit/d9fc795487f74531ea43760469cc215858d0d908 -- nosy: +

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by Tal Einat : -- pull_requests: +8120 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by miss-islington : -- pull_requests: +8119 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Tal Einat added the comment: New changeset 10ea9409ceb5da83cb380b610750551e26561044 by Tal Einat in branch 'master': bpo-34120: fix IDLE freezing after closing dialogs (GH-8603) https://github.com/python/cpython/commit/10ea9409ceb5da83cb380b610750551e26561044 -- ___

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Terry J. Reedy added the comment: Removing 2.7 was unintended, from simultaneous editing. This is one of the exceptional cases where a backport is worth the risk (which seems here extremely low). I will remove it from the PR because auto backport will fail because of file renames, in addit

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Tal Einat added the comment: Why remove the 2.7 version? This bug occurs with 2.7.15 on macOS. -- ___ Python tracker ___ ___ Python

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Terry J. Reedy added the comment: I wrote the following justification for adding grab_release while Tal was revising his PR to make the change. I will look at the PR now and test on Windows. --- Vlad, I was wondering about modality. Properly de-modalizing a dialog requires more than just

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by Tal Einat : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by Tal Einat : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Tal Einat added the comment: Adding grab_release() calls also resolves the issue. Tested on mac and win. PR updated with this approach, IMO ready for review. -- ___ Python tracker __

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Vlad Tudorache added the comment: I've checked again the source code in config_key.py, configdialog.py, help_about.py, query.py, searchbase.py, textview.py and added a self.grab_release() in functions like ok() and cancel() before the call to self.destroy() and I see no more lock/focus issue

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Vlad Tudorache added the comment: Adding self.grab_release() in the ok() method for the dialogs BEFORE destroy() solved the problem for me, keeping the grab_set() methods in place (uncommented, actives). -- ___ Python tracker

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Vlad Tudorache added the comment: I can confirm that removing the grab_set() calls fixes the locking. But am I the only one to notice that the dialogs aren't modal any more? -- ___ Python tracker __

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Tal Einat added the comment: Confirmed on macOS 10.13.5 with the new Python 2.7.15 64-bit from python.org which bundles Tcl/Tk 8.6.8. The same fix works: Removing the grab_set() calls fixes the freezing after closing the about and config dialogs. --

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Tal Einat added the comment: I can confirm that removing .grab_set() calls fixes this issue on macOS 10.13.5 with Python 3.7.0 from python.org. Searching for those calls in all of IDLE's code lead me to discover additional similar issues, e.g. with the search dialog and the text viewer. Rem

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Change by Tal Einat : -- keywords: +patch pull_requests: +8110 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Terry J. Reedy added the comment: The tkinter doc could use a section on 'OS-tk peculiarities and interactions' ;-). Anyway, thanks again. Some of the 'Windows peculiarities' I noted above, where the test behaved better on Mac, may be due to the absence of calls that should be avoided on M

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Kevin Walzer added the comment: Removing the call "self.grab_set" in configdialog.py (line 87 or so) and help_about.py (line 47 or so) appears to fix the problem with the main window freezing when the modal dialog is destroyed on macOS. "Grab" has never worked properly on Tk on the Mac, but

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Terry J. Reedy added the comment: As with the tooltip modules (see #34275, msg322824), the dialog modules all have run-when-main test functions. Unittests are also run, before the human-verified test. python3 -m idlelib.searchbases fails in that the driver-box is not activated (lighted) wh

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Kevin Walzer added the comment: I've observed this behavior myself, and wonder if you are hitting some edge case in Tk-Mac event processing (there used to be a lot of issues with this and we thought we had addressed them). I don't want to code-dive into Python's implementation of these dialo

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Terry J. Reedy added the comment: After more experiments on Windows, the 'stuck' window -- active, no cursor, only copy works -- is a read-only window. I looked at other windows. Modal Edit > Find (Command F) Edit > Replace (Command R) When closed, neither window is activated. This seems wro

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Terry J. Reedy added the comment: I closed #34281 as a duplicate of this. Eric Martin said "After entering a line number, clicking OK brings to the foreground and makes active the first hidden window (in the simplest case where we have just one window for a .py file and the Shell window, th

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Terry J. Reedy added the comment: Thanks. This is evidence for my suspicion that this results from a problem with the new tkinter/tcl/tk8.6 delivered with 3.7. See #34275. PS: when replying by email, please delete the quote, which is redundant with the post on the web page. -- dep

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Vlad Tudorache added the comment: I’m sorry for not being clear. This problem appears with Tk 8.6, even in Python 3.5 (compiled by me). I’ve succeeded to reproduce only once the @autorelease pool error (it appeared after several open/close of the preferences or about window). Did anyone else see

[issue34120] IDLE: Freeze when closing Settings (& About) dialog on MacOS

Terry J. Reedy added the comment: On idledev thread "Mac IDLE 3.7.0 freezes when accessing Preferences", Walter Schnyder reported something similar. Combining two posts: "using python.org Python 3.7.0 (v3.7.0:1bf9cc5093, Jun 26 2018, 23:26:24) [Clang 6.0 (clang-600.0.57)] on darwin [64-bit]