[issue34056] checked hash-based pyc files not working with imp module

2018-07-06 Thread miss-islington
miss-islington added the comment: New changeset 7bd6f0e5500f778e940374237b94651f60ae1990 by Miss Islington (bot) in branch '3.7': closes bpo-34056: Always return bytes from _HackedGetData.get_data(). (GH-8130) https://github.com/python/cpython/commit/7bd6f0e5500f778e940374237b94651f60ae1990

[issue34056] checked hash-based pyc files not working with imp module

2018-07-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +7716 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34056] checked hash-based pyc files not working with imp module

2018-07-06 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset b0274f2cddd36b49fe5080efbe160277ef546471 by Benjamin Peterson in branch 'master': closes bpo-34056: Always return bytes from _HackedGetData.get_data(). (GH-8130) https://github.com/python/cpython/commit/b0274f2cddd36b49fe5080efbe160277ef54647

[issue34056] checked hash-based pyc files not working with imp module

2018-07-05 Thread Benjamin Peterson
Change by Benjamin Peterson : -- keywords: +patch pull_requests: +7708 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue34056] checked hash-based pyc files not working with imp module

2018-07-05 Thread Benjamin Peterson
Benjamin Peterson added the comment: I see. Thanks for being an early adopter! We can probably hack something together for imp. I'll send a PR in a moment. Filing bugs about imp usage would be valuable, especially if it flushes out any cases where imp provides functionality that our newer AP

[issue34056] checked hash-based pyc files not working with imp module

2018-07-05 Thread Patrick McCarty
Patrick McCarty added the comment: Thanks for the response. I would like to avoid using imp, but I work on a distro team that ships many packages that still use the module. We wanted to start using checked-hash invalidation right away after upgrading to 3.7.0, but some of our release tests

[issue34056] checked hash-based pyc files not working with imp module

2018-07-05 Thread Benjamin Peterson
Benjamin Peterson added the comment: Can you not use imp? It's been deprecated since 3.4 and gradually become more and more broken and useless as this and other import improvements (e.g., namespace packages) have happened. -- nosy: +benjamin.peterson

[issue34056] checked hash-based pyc files not working with imp module

2018-07-05 Thread Patrick McCarty
Change by Patrick McCarty : Added file: https://bugs.python.org/file47672/imp-test-mod.py ___ Python tracker ___ ___ Python-bugs-list mailin

[issue34056] checked hash-based pyc files not working with imp module

2018-07-05 Thread Patrick McCarty
New submission from Patrick McCarty : OS: Clear Linux build 23460 Python version: 3.7.0 Description: I am seeing an uncaught exception in Python 3.7.0 when using the "imp" module to import a module that has a checked hash-based pyc file. See the attached source files. Steps to reproduce: 1)