[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

Change by Mickaël S. : -- keywords: +patch pull_requests: +8045 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-

[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

Mickaël S. added the comment: Little word to say I am working on at EuroPython 2018. -- nosy: +Tiger-222 ___ Python tracker ___ ___

[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

Evgeny Prilepin added the comment: Hi Rémi, it would be great if you posted a PR. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

Rémi Lapeyre added the comment: Hi Evegeny, I was able to reproduce the issue, if it's all right for you I would like to post a PR to solve the issue and extend the test suite od this module. -- nosy: +remi.lapeyre ___ Python tracker

[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

Evgeny Prilepin added the comment: I think the line 1031 also contains the misprint and will raise NameError. > self._decompressor = zipfile._get_decompressor(self._compress_type) "zipfile." is not correct code in this place. -- ___ Python tracker

[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

Change by Serhiy Storchaka : -- keywords: +easy nosy: +serhiy.storchaka stage: -> needs patch type: crash -> behavior versions: +Python 3.6, Python 3.8 ___ Python tracker ___

[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

New submission from Evgeny Prilepin : The misprint in the file lib/zipfile.py in the line 704 leads to AttributeError: '_SharedFile' object has no attribute 'writing' "self.writing()" should be replaced by "self._writing()". I also think this code shold be covered by tests. -- compon