[issue34004] Acquiring locks not interrupted by signals on musl libc

Benjamin Peterson added the comment: On Wed, Sep 12, 2018, at 16:03, Joseph Sible wrote: > 2. Most of the time, counting on receiving an EINTR results in race > conditions. Our code seems to be affected by this too. Even on glibc, a > signal at just the "right" time could result in it not bei

[issue34004] Acquiring locks not interrupted by signals on musl libc

Joseph Sible added the comment: Re musl changing their behavior, see https://www.openwall.com/lists/musl/2018/09/07/1 and the resulting thread. In addition to the old kernel version issue, two other issues were raised: 1. EINTR makes programming mistakes more likely, as people won't think to

[issue34004] Acquiring locks not interrupted by signals on musl libc

Benjamin Peterson added the comment: Reimplementing locks with eventfd can be another issue. Such a change can only land in a new Python version, though. We'll just have to consider musl unsupported for interrupting locks in our current maintenance releases as I have done. How likely is it

[issue34004] Acquiring locks not interrupted by signals on musl libc

Joseph Sible added the comment: How is this considered "fixed"? Why couldn't this be actually fixed by using eventfd instead of semaphores when they're available, for example? -- ___ Python tracker

[issue34004] Acquiring locks not interrupted by signals on musl libc

miss-islington added the comment: New changeset 5a435eac1b83f080c9dfceff0de0d639541e4bcb by Miss Islington (bot) in branch '3.6': closes bpo-34004: Skip lock interruption tests on musl. (GH-9224) https://github.com/python/cpython/commit/5a435eac1b83f080c9dfceff0de0d639541e4bcb -- _

[issue34004] Acquiring locks not interrupted by signals on musl libc

miss-islington added the comment: New changeset b608fcd444c00ff37a19d34e4eeadb1221fb6436 by Miss Islington (bot) in branch '3.7': closes bpo-34004: Skip lock interruption tests on musl. (GH-9224) https://github.com/python/cpython/commit/b608fcd444c00ff37a19d34e4eeadb1221fb6436 -- no

[issue34004] Acquiring locks not interrupted by signals on musl libc

Change by miss-islington : -- pull_requests: +8658 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34004] Acquiring locks not interrupted by signals on musl libc

Benjamin Peterson added the comment: New changeset 5b10d5111d7a855297654af9045f8907b7d3dd08 by Benjamin Peterson in branch 'master': closes bpo-34004: Skip lock interruption tests on musl. (GH-9224) https://github.com/python/cpython/commit/5b10d5111d7a855297654af9045f8907b7d3dd08 --

[issue34004] Acquiring locks not interrupted by signals on musl libc

Change by miss-islington : -- pull_requests: +8657 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34004] Acquiring locks not interrupted by signals on musl libc

Change by Benjamin Peterson : -- keywords: +patch pull_requests: +8655 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue34004] Acquiring locks not interrupted by signals on musl libc

New submission from Joseph Sible : When Python is built on Alpine Linux or in any other configuration that uses musl libc, calls to Lock.acquire() can't be interrupted by signals. This bug is caught by test_lock_acquire_interruption and test_rlock_acquire_interruption in 3.6/Lib/test/test_thr