[issue3392] subprocess fails in select when descriptors are large

Benjamin Peterson added the comment: I will retag 3.1.1rc then... -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue3392] subprocess fails in select when descriptors are large

Gregory P. Smith added the comment: merged into release31-maint in r74425. reopen the issue if this doesn't fix the problem. -- status: open -> closed versions: -Python 2.6 ___ Python tracker

[issue3392] subprocess fails in select when descriptors are large

Gregory P. Smith added the comment: r73916 appears to fix this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue3392] subprocess fails in select when descriptors are large

Martin v. Löwis added the comment: Unfortunately, this change has broken windows support of the subprocess module, which now reports, on "import subprocess". >>> import subprocess Traceback (most recent call last): File "", line 1, in File "C:\loewis\31\python\lib\subprocess.py", line 390,

[issue3392] subprocess fails in select when descriptors are large

Frank Chu added the comment: Thanks! Good to hear it's checked in finally :-). Frank On Fri, Jul 3, 2009 at 7:47 PM, Gregory P. Smith wrote: > > Gregory P. Smith added the comment: > > Merged to py3k in r73833. > > -- > > ___ > Python tracker > <

[issue3392] subprocess fails in select when descriptors are large

Gregory P. Smith added the comment: Merged to py3k in r73833. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3392] subprocess fails in select when descriptors are large

Gregory P. Smith added the comment: Your patch looks pretty good. I cleaned up a few things in it and added a unittest (the existing test suite is run with both select and poll). Committed to trunk in r73825. I am leaving the issue open until this is ported and merged into py3k as well as bac

[issue3392] subprocess fails in select when descriptors are large

Amaury Forgeot d'Arc added the comment: The patch looks good to me, but I don't use Linux regularly. Another review is needed! -- keywords: +needs review nosy: +amaury.forgeotdarc stage: -> patch review ___ Python tracker

[issue3392] subprocess fails in select when descriptors are large

Frank Chu added the comment: Updated with new patch. I moved the try: except logic in the module initialization step so I get a global has_poll, similar to the global mswindows already there. I now use a try/except/else to be more robust (not needed now since it's only "has_poll = True", but I

[issue3392] subprocess fails in select when descriptors are large

Mike Coleman added the comment: My original report didn't mention it specifically, but I believe I was hitting the FD_SETSIZE limit that Frank mentioned. (Thanks for working on this!) -- ___ Python tracker ___

[issue3392] subprocess fails in select when descriptors are large

Mattias Engdegård added the comment: The patch looks all right in general. I would use something like if "poll" in dir(select) instead of catching AttributeError which risks hiding bugs in _communicate_with_poll(). PEP8 probably wants spaces around the bitwise-or operator. Some systems cann

[issue3392] subprocess fails in select when descriptors are large

Frank Chu added the comment: Hi, This is a patch that uses poll() in subprocess.communicate() if it is available. This is my first patch and may contain style errors. I try to conform to PEP 8 as close as I can. Besides the discussion here, I would like to add this is desired because select(

[issue3392] subprocess fails in select when descriptors are large

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue3392] subprocess fails in select when descriptors are large

Mike Coleman added the comment: I also ran into this bug. In my case I'm able to work around this by "reserving" some fds at the start of my program (open 20 reserved fds, open 2000 real fds, close 20 reserved fds), but this is both a kludge and not a general solution. Probably virtually all

[issue3392] subprocess fails in select when descriptors are large

Mattias Engdegård <[EMAIL PROTECTED]> added the comment: As the comment in the original bug report said, you need to raise the file descriptor limit to something well above 2000 before running the test case. Needless to say, you may need to do that part as root in case that would exceed your har

[issue3392] subprocess fails in select when descriptors are large

STINNER Victor <[EMAIL PROTECTED]> added the comment: I don't understand the problem. If you open a lot of files, the open() loop will stop an exception (IOError: too many open files), and so subprocess is not used. If I open -1 files, subprocess._get_handles() will fail on os.pipe(). If I o

[issue3392] subprocess fails in select when descriptors are large

Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3392] subprocess fails in select when descriptors are large

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- priority: -> normal type: -> behavior versions: +Python 2.6, Python 3.0 -Python 2.5 ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3392] subprocess fails in select when descriptors are large

Changes by David Kågedal <[EMAIL PROTECTED]>: -- nosy: +d_kagedal ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailin

[issue3392] subprocess fails in select when descriptors are large

New submission from Mattias Engdegård <[EMAIL PROTECTED]>: If the stdin/out file descriptors are too large to be used with select(), subprocess will fail in .communicate(). Example: # raise the fd limit to something like 2048 before running this import subprocess somefiles = [open("/etc/passwd")