[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe the colorizer would need some new code, maybe in a subclass, but it should be possible. I would not know if I liked it until we tried it ;-). -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-04 Thread miss-islington
miss-islington added the comment: New changeset b7eb1024d06e51598fc8a19ed6e22b91120c6a1e by Miss Islington (bot) in branch '3.7': bpo-33763: IDLE: Replace label widget with text widget in code context (GH-7367) https://github.com/python/cpython/commit/b7eb1024d06e51598fc8a19ed6e22b91120c6a1e

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-04 Thread miss-islington
miss-islington added the comment: New changeset ffe29dbcd96dc2fbda212f8335908fa1bc8ed893 by Miss Islington (bot) in branch '3.6': bpo-33763: IDLE: Replace label widget with text widget in code context (GH-7367) https://github.com/python/cpython/commit/ffe29dbcd96dc2fbda212f8335908fa1bc8ed893

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +7026 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +7025 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset b609e687a076d77bdd687f5e4def85e29a044bfc by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-33763: IDLE: Replace label widget with text widget in code context (GH-7367) https://github.com/python/cpython/commit/b609e687a076d77bdd687f5e4d

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-04 Thread Cheryl Sabella
Cheryl Sabella added the comment: To your point, when I was adding the colors to configuration for context, I wondered if having context as a text widget could somehow use the colorizer. I didn't really look into it, but it did seem like it might make sense to keep all the foreground text c

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: This makes detecting the context line a user clicks on slightly easier. See new issue #33768 for discussion. I am not sure now I would do this just for this reason, without trying with the label first. Using a text also allows us to experiment with tagging

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-03 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +6993 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue33763] IDLE: Use text widget for code context instead of label widget

2018-06-03 Thread Cheryl Sabella
New submission from Cheryl Sabella : Item 11 from #33610. Use read-only Text instead of Label for context. * Change widget type from Label to Text and remove Label-only arguments. * Add height and state arguments. * Change widget name from self.label to self.context. * Tests: change widget nam