[issue33140] shutil.chown should not be defined in Windows

Eryk Sun added the comment: > creating a Windows `os.set_owner` function that uses the > appropriate Windows API calls to change owner/group settings, > and then using that for Windows in the `shutil.chown` function? I'd gladly help with implementing os.set_owner(), as a separate issue. But I

[issue33140] shutil.chown should not be defined in Windows

Ryan Mast (nightlark) added the comment: If this function were to be implemented on Windows would the preferred approach be the one described in the initial message for this issue of creating a Windows `os.set_owner` function that uses the appropriate Windows API calls to change owner/group

[issue33140] shutil.chown should not be defined in Windows

Jack DeVries added the comment: Yes, I definitely get that, but that's what the deprecation cycle is for. Certainly hold off on a PR until we see what @steve.dower thinks. I personally feel that having a function that can be introspected with ``dir`` but which should not be used is confusing

[issue33140] shutil.chown should not be defined in Windows

Andrei Kulakov added the comment: Jack: I'm not sure if this eventual fix is worth doing.. it might cause issues for users to leave it as is, but can also cause issues to remove it even after deprecation period; I don't have a good feeling if one is more likely than the other, - so I'll have

[issue33140] shutil.chown should not be defined in Windows

Jack DeVries added the comment: I'm pretty sure the 3.11 dev cycle started since this conversation, right? Can we introduce the deprecation warning now? Maybe something like what is in the attached diff? @andrei.avk, if it turns out that the time has come, you can go ahead and take the PR i

[issue33140] shutil.chown should not be defined in Windows

Andrei Kulakov added the comment: Steve: makes sense, I closed the PR; thanks for looking at this and taking the time to explain! -- ___ Python tracker ___ __

[issue33140] shutil.chown should not be defined in Windows

Steve Dower added the comment: I agree that's theoretically how it should go, but we've had enough examples of undocumented/buggy behaviour where the fix was worse than the bug (to the point where we brought back an undocumented C field that was deprecated in 3.0 because removing it in 3.8 b

[issue33140] shutil.chown should not be defined in Windows

Andrei Kulakov added the comment: Steve: it seems to me that the goal of normal deprecation process is, given that a functionality is available and documented, prepare to find a replacement for it by some future version. In this case it's documented not to be available and doesn't work so th

[issue33140] shutil.chown should not be defined in Windows

Steve Dower added the comment: We can't delete the definition without going through a deprecation process, as it will break existing code with a new exception at the point of access rather than the point of use. At best, we can short-circuit those errors and raise them with a more appropriat

[issue33140] shutil.chown should not be defined in Windows

Andrei Kulakov added the comment: Created the PR: https://github.com/python/cpython/pull/26973/files -- ___ Python tracker ___ ___

[issue33140] shutil.chown should not be defined in Windows

Change by Andrei Kulakov : -- keywords: +patch nosy: +andrei.avk nosy_count: 6.0 -> 7.0 pull_requests: +25537 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/26973 ___ Python tracker

[issue33140] shutil.chown should not be defined in Windows

Change by Kamil Turek : -- nosy: +kamilturek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue33140] shutil.chown should not be defined in Windows

Change by Eryk Sun : -- title: shutil.chown on Windows -> shutil.chown should not be defined in Windows ___ Python tracker ___ ___ P