[issue32741] Add asyncio.TimerHandle.when() function

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue32741] Add asyncio.TimerHandle.when() function

Change by miss-islington : -- pull_requests: +5310 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32741] Add asyncio.TimerHandle.when() function

Andrew Svetlov added the comment: Thanks. Let's do it. The addition is really very trivial. -- ___ Python tracker ___ ___ Python-bug

[issue32741] Add asyncio.TimerHandle.when() function

Yury Selivanov added the comment: Andrew, I'm indifferent about this feature. It's entirely up to you if you want to merge it in 3.7. I already used up my allowance for post-beta1 feature merges. -- ___ Python tracker

[issue32741] Add asyncio.TimerHandle.when() function

Ned Deily added the comment: We have feature freezes for a good reason. But I will trust your judgement on this one. (Removing 3.6 for version list.) -- versions: -Python 3.6 ___ Python tracker ___

[issue32741] Add asyncio.TimerHandle.when() function

Yury Selivanov added the comment: > Let's get it into master for 3.8 first and then we'll have something to > discuss. The PR has a "versionadded" tag. If you plan to allow this, Andrew can commit it set to 3.7... -- ___ Python tracker

[issue32741] Add asyncio.TimerHandle.when() function

Change by Andrew Svetlov : -- keywords: +patch pull_requests: +5300 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue32741] Add asyncio.TimerHandle.when() function

Yury Selivanov added the comment: The PR is LGTM. Up to Ned to allow this in 3.7. I agree that the feature is (a) trivial, (b) new, so it's safe to go in 3.7. -- ___ Python tracker

[issue32741] Add asyncio.TimerHandle.when() function

Ned Deily added the comment: Let's get it into master for 3.8 first and then we'll have something to discuss. -- ___ Python tracker ___

[issue32741] Add asyncio.TimerHandle.when() function

Yury Selivanov added the comment: OK, makes sense. Can you submit a PR? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32741] Add asyncio.TimerHandle.when() function

Andrew Svetlov added the comment: In aiohttp we have HTTP keepalivve support. A function schedules a delayed callback. On processing a new request the callback is cancelled and rescheduled to a new time. I like to check cancellation state (now it is possible with public API) and scheduled ti

[issue32741] Add asyncio.TimerHandle.when() function

Yury Selivanov added the comment: How will such test look like? I'm still not sure we need it. -- ___ Python tracker ___ ___ Python-

[issue32741] Add asyncio.TimerHandle.when() function

New submission from Andrew Svetlov : Should just return self._when attribute. I need it for testing purposes. Without the method there is no possibility to figure out scheduled wakeup time. An alternative is waiting for callback but the approach increases unittest execution time and not very re