[issue32587] Make REG_MULTI_SZ support PendingFileRenameOperations

Change by Zackery Spytz : -- nosy: +ZackerySpytz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue32587] Make REG_MULTI_SZ support PendingFileRenameOperations

Change by Zackery Spytz : -- keywords: +patch pull_requests: +13149 stage: needs patch -> patch review ___ Python tracker ___ ___ Py

[issue32587] Make REG_MULTI_SZ support PendingFileRenameOperations

Eryk Sun added the comment: Currently countStrings and fixupMultiSZ halt the outer loop as soon as they hit an empty string. Basically, we'd be getting rid of that check. Then we have to prevent including an empty string for the final NUL in the normal case. We can do this by decrementing the

[issue32587] Make REG_MULTI_SZ support PendingFileRenameOperations

Seppo Yli-Olli added the comment: I don't personally know enough of CPython (I barely know enough C) to do the patches but I'd just comment that as this might increase complexity of implementation and wide char API's are used, it might be prudent to make sure the new implementation works with

[issue32587] Make REG_MULTI_SZ support PendingFileRenameOperations

Steve Dower added the comment: I don't think it's too late (and I don't think this counts as a feature either, so the b1 deadline doesn't apply), but the patch would need to include an update to What's New as well as the usual stuff. -- ___ Python

[issue32587] Make REG_MULTI_SZ support PendingFileRenameOperations

Eryk Sun added the comment: PyWin32's win32api.RegQueryValueEx and win32api.RegEnumValue also use the same documented interpretation of REG_MULTI_SZ [1] (i.e. a "sequence of null-terminated strings, terminated by an empty string"). [1]: https://msdn.microsoft.com/en-us/library/ms724884 Howev

[issue32587] Make REG_MULTI_SZ support PendingFileRenameOperations

Change by Ned Deily : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___ Python

[issue32587] Make REG_MULTI_SZ support PendingFileRenameOperations

New submission from Seppo Yli-Olli : MSDN documents that REG_MULTI_SZ is not supposed to have \0\0 anywhere else than in the end. The comment in https://github.com/python/cpython/blob/a5293b4ff2c1b5446947b4986f98ecf5d52432d4/PC/winreg.c#L504 clearly shows that Python has the assumption that th