[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

STINNER Victor added the comment: I just merged PR 8548. See the PR to the discussion. IMHO it's a nice enhancement to have a pure Python implementation: https://github.com/python/cpython/pull/8548#issuecomment-433063178 (and the PR has been approved by 2 other core devs ;-)) But I'm against

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Change by miss-islington : -- pull_requests: +9425 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

STINNER Victor added the comment: New changeset e25d5fc18e6c4b0062cd71b2eb1fd2d5eb5e2d3d by Victor Stinner (madman-bob) in branch 'master': bpo-32321: Add pure Python fallback for functools.reduce (GH-8548) https://github.com/python/cpython/commit/e25d5fc18e6c4b0062cd71b2eb1fd2d5eb5e2d3d --

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Change by Serhiy Storchaka : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Change by Braden Groom : -- pull_requests: +9246 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Change by Robert Wright : -- pull_requests: +8064 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Nick Coghlan added the comment: Reviewing the code and the CI test failures on the PR, the trick here is that functools isn't actually *using* functools.reduce, it's just re-exporting it if it's defined. So if you block importing of "_functools" (which the test suite does in order to test th

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Andrew Svetlov added the comment: See discussion in https://bugs.python.org/issue12428 (especially the last message) -- nosy: +asvetlov ___ Python tracker ___

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Change by Srinivas Reddy T : -- keywords: +patch pull_requests: +4841 stage: -> patch review ___ Python tracker ___ ___ Python-bugs

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Change by Raymond Hettinger : -- assignee: -> ncoghlan nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

New submission from Steven D'Aprano : The functools module imports reduce from _functools, using a guard in case it is not present: try: from _functools import reduce except ImportError: pass However, the documentation says nothing about reduce being optional, and it is unconditional