[issue32129] Icon on macOS

2019-02-25 Thread Ned Deily
Change by Ned Deily : -- pull_requests: +12064 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue32129] Icon on macOS

2019-02-25 Thread Ned Deily
Change by Ned Deily : -- pull_requests: +12061 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue32129] Icon on macOS

2019-02-25 Thread Kevin Walzer
Kevin Walzer added the comment: Is there any reason not to commit the patch I submitted to address this issue?As an alternative I can submit a high-res PNG that can be used, and will submit a different patch to incorporate it, which would work from either the standard app bundle or the comma

[issue32129] Icon on macOS

2019-01-26 Thread Kevin Walzer
Kevin Walzer added the comment: Making the icon 512x512 pixels will make it look correct on Retina displays on the Mac. -- ___ Python tracker ___

[issue32129] Icon on macOS

2019-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: A Branch Seidenman posted 'Retina Icons' on idle-dev. He posted a screenshot similar to Kevin's. He says Apple recommends having all these sizes: 1024px × 1024px 512px × 512px 256px × 256px 128px × 128px 64px × 64px 32px × 32px 16px × 16px Creating new icons

[issue32129] Icon on macOS

2017-11-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If on OS X only first picture is taken, what if change the order of pictures? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue32129] Icon on macOS

2017-11-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ned, do you agree that simply changing 'else' to 'elif not macosx.isAquaTk()' is the best resolution? Backporting such a change to 3.6 would be trivial; to 2.7, not. Is there any need for the latter? Kevin, thanks for the explanation. -- _

[issue32129] Icon on macOS

2017-11-25 Thread Kevin Walzer
Kevin Walzer added the comment: Adding proposed patch. -- keywords: +patch Added file: https://bugs.python.org/file47293/pyshell.diff ___ Python tracker ___ ___

[issue32129] Icon on macOS

2017-11-25 Thread Kevin Walzer
Kevin Walzer added the comment: wm_iconphoto is a no-op on Tk 8.5 on MacOS; the C function returns true with no action. That's why this has not cropped up before. As implemented, the command on macOS only takes the first image in the parameters to use; the Cocoa mechanism in use for displayin

[issue32129] Icon on macOS

2017-11-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: Here is the current code in idlelib.pyshell.main. # set application icon icondir = os.path.join(os.path.dirname(__file__), 'Icons') if system() == 'Windows': iconfile = os.path.join(icondir, 'idle.ico') root.wm_iconbitmap(default=ico

[issue32129] Icon on macOS

2017-11-24 Thread Kevin Walzer
New submission from Kevin Walzer : The trunk and 8.6.7 branch of Tk on macOS have recently implemented the wm_iconphoto command, which had not previously been supported on macOS. This means that versions of IDLE that link to this version of Tk will inherit the iconphoto behavior on Windows and