[issue32100] IDLE: PathBrowser isn't working

2017-11-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 38ecf57306ef25874ef7c44a9875771e90faee97 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.6': bpo-32100: Delete unneeded import in idlelib.pathbrowser. (GH-4626) (#4629) https://github.com/python/cpython/commit/38ecf57306ef25874ef7c44a98757

[issue32100] IDLE: PathBrowser isn't working

2017-11-28 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4544 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue32100] IDLE: PathBrowser isn't working

2017-11-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset fd6f8c56b9a757210e8ceaea9edc50e502dc2085 by Terry Jan Reedy in branch 'master': bpo-32100: Delete unneeded import in idlelib.pathbrowser. (#4626) https://github.com/python/cpython/commit/fd6f8c56b9a757210e8ceaea9edc50e502dc2085 --

[issue32100] IDLE: PathBrowser isn't working

2017-11-28 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +4541 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32100] IDLE: PathBrowser isn't working

2017-11-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thanks for catching and fixing this. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue32100] IDLE: PathBrowser isn't working

2017-11-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset ae3c5c7b9e5e5ba53213e12cc100e32415d5762c by Terry Jan Reedy in branch '3.6': [3.6] bpo-32100: IDLE: Fix pathbrowser errors; improve tests. (GH-4484) (#4512) https://github.com/python/cpython/commit/ae3c5c7b9e5e5ba53213e12cc100e32415d5762c -

[issue32100] IDLE: PathBrowser isn't working

2017-11-22 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +4449 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32100] IDLE: PathBrowser isn't working

2017-11-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 20d48a44a54ed5e4a6df00e89ae27e3983128265 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-32100: IDLE: Fix pathbrowser errors; improve tests. (#4484) https://github.com/python/cpython/commit/20d48a44a54ed5e4a6df00e89ae27e3983128265 -

[issue32100] IDLE: PathBrowser isn't working

2017-11-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: The reason double-clicking got worse from 3.6.3 to now is this. Previously, browser.ModuleBrowserTreeItem.OnDoubleClick ignored the file_open global (set to pyshell.flist.open in .__init__) and called pyshell.flist.open. The Class and Method OnDoubleClick c

[issue32100] IDLE: PathBrowser isn't working

2017-11-21 Thread Cheryl Sabella
Cheryl Sabella added the comment: I added a test for PathBrowser, but I didn't change the existing tests, except to move them to their own test class. -- ___ Python tracker __

[issue32100] IDLE: PathBrowser isn't working

2017-11-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: The issue is this: 1. PathBrowser subclasses ModuleBrowser. 2. ModuleBrowser.init() has the common code for initializing both. 3. #31460 changed the signature of ModuleBrowser.__init__ *and* .init. 4. I must not have tested pathbrowser after the .init change. B

[issue32100] IDLE: PathBrowser isn't working

2017-11-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Error is printed in console window if IDLE started from one. >>> import idlelib.idle # Select pathbrowser in File menu Exception in Tkinter callback Traceback (most recent call last): File "F:\dev\3x\lib\tkinter\__init__.py", line 1699, in __call__ return

[issue32100] IDLE: PathBrowser isn't working

2017-11-20 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +4421 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue32100] IDLE: PathBrowser isn't working

2017-11-20 Thread Cheryl Sabella
New submission from Cheryl Sabella : Clicking on Path Browser in the File menu gives an error instead of opening the Path Browser. -- assignee: terry.reedy components: IDLE messages: 306606 nosy: csabella, terry.reedy priority: normal severity: normal status: open title: IDLE: PathBrows