[issue32033] The pwd module implementation incorrectly sets some attributes to None

Christian Heimes added the comment: New changeset 4aea656d62860e78cd8384f2de375f0d4f1db579 by Christian Heimes in branch 'main': bpo-32033: Finalize WASI configure options (GH-32053) https://github.com/python/cpython/commit/4aea656d62860e78cd8384f2de375f0d4f1db579 -- __

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Change by Christian Heimes : -- nosy: +christian.heimes nosy_count: 5.0 -> 6.0 pull_requests: +30143 pull_request: https://github.com/python/cpython/pull/32053 ___ Python tracker _

[issue32033] The pwd module implementation incorrectly sets some attributes to None

miss-islington added the comment: New changeset 8821200d85657ef3bbec78dcb43694449c05e896 by Miss Islington (bot) in branch '3.7': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/8821200d85657ef3bbec78dcb43694449c05e896 --

[issue32033] The pwd module implementation incorrectly sets some attributes to None

miss-islington added the comment: New changeset 1e1dbdf23f7a18f53a3257badc3541973831f2c4 by Miss Islington (bot) in branch '3.8': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/1e1dbdf23f7a18f53a3257badc3541973831f2c4 --

[issue32033] The pwd module implementation incorrectly sets some attributes to None

STINNER Victor added the comment: It's now fixed in master and backports to 3.7 and 3.8 will be merged as soon as the CI pass. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Change by miss-islington : -- pull_requests: +18869 pull_request: https://github.com/python/cpython/pull/19519 ___ Python tracker ___ __

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +18868 pull_request: https://github.com/python/cpython/pull/19518 ___ Python tracker _

[issue32033] The pwd module implementation incorrectly sets some attributes to None

STINNER Victor added the comment: New changeset 96515e9f6785328c52ebc5d4ce60e0087a9adc2d by Zackery Spytz in branch 'master': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/96515e9f6785328c52ebc5d4ce60e0087a9adc2d --

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Change by Zackery Spytz : -- versions: +Python 3.8, Python 3.9 -Python 2.7, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list m

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 3.0 -> 4.0 pull_requests: +18853 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/19502 ___ Python tracker

[issue32033] The pwd module implementation incorrectly sets some attributes to None

STINNER Victor added the comment: > And at least for pw_shell the behavior for NULL and "" are different. What is the difference between the two? -- ___ Python tracker ___ ___

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Serhiy Storchaka added the comment: On your second link it is documented explicitly that pw_dir and pw_shell might be NULL. And at least for pw_shell the behavior for NULL and "" are different. -- ___ Python tracker

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Xavier de Gaye added the comment: Changing test_pwd does not correct the fact that the current implementation of the pwd module may break an existing Python application since this (old indeed) API states "The uid and gid items are integers, all others are strings". > returning an empty string

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Serhiy Storchaka added the comment: I disagree. This is an old API, a thin wrapper around standard POSIX API, and returning an empty string instead of None will make impossible to distinguish NULL from "". It is easy to convert None in an empty string in Python: `value or ''`. I would change

[issue32033] The pwd module implementation incorrectly sets some attributes to None

Xavier de Gaye added the comment: > I'm not sure that it's very useful to distinguish NULL and an empty char* > string. I agree. An attribute of a ('pwd' Python module) password database entry corresponds to the field of a line in a 'passwd' text file. So it makes sense that when the field i