[issue3182] 2to3 Slight Patch

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- resolution: -> rejected status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3182] 2to3 Slight Patch

Nick Edds <[EMAIL PROTECTED]> added the comment: Fair enough. I guess that even though there's a little bit of a performance improvement from this, it does hurt extensibility, so its probably not a worthwhile change after all. ___ Python tracker <[EMAIL PROTEC

[issue3182] 2to3 Slight Patch

Collin Winter <[EMAIL PROTECTED]> added the comment: So, revisiting this... On the face of it, I'm not convinced that the isinstance(x, Leaf) -> type(x) is Leaf changes are correct: certain fixers have in the past utilized their own subclasses of Node, and I can foresee this being done again in

[issue3182] 2to3 Slight Patch

Nick Edds <[EMAIL PROTECTED]> added the comment: I don't think the improvement falls in margin of error, but maybe I'm wrong. The problem was that even when just run on a single file, isinstance was being called upwards of 100,000 times. I guess it doesn't merit inclusion on its own though, but w

[issue3182] 2to3 Slight Patch

Collin Winter <[EMAIL PROTECTED]> added the comment: I'm not wild about making this change for such a minimal improvement (which I would guess falls within the margin of error), since it will limit extensibility and testability. I think I'd be fine with it if the benefit were >10%, but 3% doesn't

[issue3182] 2to3 Slight Patch

New submission from Nick Edds <[EMAIL PROTECTED]>: This is a small patch to the 2to3 tool, replacing some calls to isinstance (x,y) with type(x) is y in the file pytree.py. Although there is only a slight performance increase for each time this change is made, the recursive nature of pattern matc