[issue31792] test_buffer altered the execution environment

Serhiy Storchaka added the comment: Thank you Victor and Stefan for your review. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.7 -Python 3.8 ___ Python tracker

[issue31792] test_buffer altered the execution environment

Serhiy Storchaka added the comment: New changeset 06949585d292d1a9dbf2d0d0fa8fc8fe1dee3ccf by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31792: Restore os.environ in test_buffer when import numpy. (GH-4007) (#4009) https://github.com/python/cpython/commit/06949585d292d

[issue31792] test_buffer altered the execution environment

Change by Roundup Robot : -- pull_requests: +3983 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue31792] test_buffer altered the execution environment

Serhiy Storchaka added the comment: New changeset 676db4bbf2e7c18dc7c35add17dd3bbdc2d3eeb3 by Serhiy Storchaka in branch 'master': bpo-31792: Restore os.environ in test_buffer when import numpy. (#4007) https://github.com/python/cpython/commit/676db4bbf2e7c18dc7c35add17dd3bbdc2d3eeb3 ---

[issue31792] test_buffer altered the execution environment

Stefan Krah added the comment: I'd push it so we don't have to worry about similar things in the future. The "warnings.catch_warnings()" thing is also a workaround for some past numpy release. -- ___ Python tracker

[issue31792] test_buffer altered the execution environment

Serhiy Storchaka added the comment: The issue is fixed on NumPy side (will be included in the next release). Is the workaround on our side still needed? -- ___ Python tracker

[issue31792] test_buffer altered the execution environment

Stefan Krah added the comment: I can't figure out how to make the damn button green on GitHub, so LGTM. :) -- ___ Python tracker ___ ___

[issue31792] test_buffer altered the execution environment

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +3981 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue31792] test_buffer altered the execution environment

Stefan Krah added the comment: That's fine. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31792] test_buffer altered the execution environment

STINNER Victor added the comment: I suggest to always save/restore env vars on numpy import, since we don't control 3rd party code. -- ___ Python tracker ___ __

[issue31792] test_buffer altered the execution environment

Stefan Krah added the comment: Thanks. If it only occurs when mixing debug/non-debug I don't think we have to do anything about it. -- ___ Python tracker ___ _

[issue31792] test_buffer altered the execution environment

Serhiy Storchaka added the comment: It is particularly a NumPy issue (I have opened a bug https://github.com/numpy/numpy/issues/9861). It is exposed because I have installed NumPy with non-debug build of CPython and run the test with debug build of CPython. The test is passes with non-debug b

[issue31792] test_buffer altered the execution environment

Stefan Krah added the comment: So it is a numpy issue? Which numpy version is it? -- versions: +Python 3.8 -Python 3.6, Python 3.7 ___ Python tracker ___ __

[issue31792] test_buffer altered the execution environment

Serhiy Storchaka added the comment: I just have installed NumPy. It temporary sets these two environment variables for importing the multiarray numpy extension module, but forgot to remove them if the import is failed. test_buffer imports numpy. try: with warnings.catch_warnings():

[issue31792] test_buffer altered the execution environment

STINNER Victor added the comment: Why the env changed wasn't noticed before? Is it a recent change? -- ___ Python tracker ___ ___ Py

[issue31792] test_buffer altered the execution environment

New submission from Serhiy Storchaka : test_buffer adds two environment variables: 'OPENBLAS_MAIN_FREE': '1', 'GOTOBLAS_MAIN_FREE': '1'. $ ./python -m test -v test_buffer ... Warning -- os.environ was modified by test_buffer Before: (140174267697792, environ({...}) After: (140174267697792,