[issue31785] Move instruction code from ceval.c to a separate file

2017-10-19 Thread Raymond Hettinger
Raymond Hettinger added the comment: No one has spoken up for this feature request, so I'm marking it as closed. Thank you for the suggestion, but I think it is prudent to decline. -- resolution: -> rejected stage: -> resolved status: open -> closed

[issue31785] Move instruction code from ceval.c to a separate file

2017-10-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: > A strict (non-leaky) abstraction interface is necessary > for being able to re-use the instruction code in an > alternate evaluator. The problem is that we don't have a strict (non-leaky) abstraction and I don't think we should impose one. > Done proper

[issue31785] Move instruction code from ceval.c to a separate file

2017-10-14 Thread pdox
pdox added the comment: rhettinger, helper functions used by the instruction code would also be moved into instructions.h (e.g. call_function, do_call_core, cmp_outcome, etc). Done properly, there should be very little need to move between instructions.h and ceval.c to understand what is happ

[issue31785] Move instruction code from ceval.c to a separate file

2017-10-13 Thread Raymond Hettinger
Raymond Hettinger added the comment: While I can see the utility for experimentation, I think the proposed change would make our lives more difficult. The body inside the instruction blocks is central to the understanding of ceval.c and somewhat tightly coupled with it. I would find it more

[issue31785] Move instruction code from ceval.c to a separate file

2017-10-13 Thread pdox
Change by pdox : -- title: Move instruction code blocks to separate file -> Move instruction code from ceval.c to a separate file ___ Python tracker ___ ___