[issue3160] Building a Win32 binary installer crashes

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Fixed in r66223. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3160] Building a Win32 binary installer crashes

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +ocean-city ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mail

[issue3160] Building a Win32 binary installer crashes

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Hi Viktor I believe no installer was released for beta3 because Martin von Löwis was on holidays and couldn't handle it. Now we are in release candidate phase, the patch needs another reviewer though. ___

[issue3160] Building a Win32 binary installer crashes

Viktor Ferenczi <[EMAIL PROTECTED]> added the comment: Note: I tested the patch with the latest beta 2 release. The Windows installer is beta2, but beta3 is announced. I don't understand why, Guido should know... ___ Python tracker <[EMAIL PROTECTED]>

[issue3160] Building a Win32 binary installer crashes

Viktor Ferenczi <[EMAIL PROTECTED]> added the comment: Thanks. I've tested the patch, it worked for me. However, I had to apply it manually. No big deal, since not a big patch, anyway. :-) ___ Python tracker <[EMAIL PROTECTED]>

[issue3160] Building a Win32 binary installer crashes

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-lis

[issue3160] Building a Win32 binary installer crashes

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Viktor? ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing list Unsubs

[issue3160] Building a Win32 binary installer crashes

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Similar issue but with bdist_msi in #3542. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ P

[issue3160] Building a Win32 binary installer crashes

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, it's a little more complicated than that, because the pre-install-script must have its newlines converted, otherwise the installer refuses to run it. Here is a working patch. Viktor, do you want to give it a try? -- assignee: ->

[issue3160] Building a Win32 binary installer crashes

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Do you really need to know the encoding of the pre_install_script? Isn't it sufficient to open it in binary mode instead? ___ Python tracker <[EMAIL PROTECTED]> __

[issue3160] Building a Win32 binary installer crashes

Viktor Ferenczi <[EMAIL PROTECTED]> added the comment: Is forcing the encoding as UTF-8 backwards compatible? It should be at least noted somewhere if this change could render existing setup scripts incompatible with Python 3.0. ___ Python tracker <[EMAIL PRO

[issue3160] Building a Win32 binary installer crashes

Senthil <[EMAIL PROTECTED]> added the comment: >> What is the expected encoding of the pre_install_script file? I think, the pre_install_script will be provided by the user. It would be safe to assume "UTF-8" for the encoding of pre_install_script -- nosy: +orsenthil ___

[issue3160] Building a Win32 binary installer crashes

Viktor Ferenczi <[EMAIL PROTECTED]> added the comment: Thanks. Good point. :-) I did not find that bug, since pre_install_script is not defined for my project. Sorry, it is my fault. I did not test my patch deep enough. I need to know one more thing before providing a better patch: What is the

[issue3160] Building a Win32 binary installer crashes

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Hi Viktor, It's complicated for me to test under Windows right now, but your snippet looks buggy: script_data = open(self.pre_install_script, "r").read() cfgdata = cfgdata + script_data + b"\n\0" script_data is an un

[issue3160] Building a Win32 binary installer crashes

Viktor Ferenczi <[EMAIL PROTECTED]> added the comment: Note: It is already fixed and should go into the next beta. Thanks. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3160] Building a Win32 binary installer crashes

Viktor Ferenczi <[EMAIL PROTECTED]> added the comment: Fixed by appending the b (bytes) prefix to three string literals concatenated to cfgdata in C:\python30\lib\distutils\command\bdist_wininst.py: Line #262: # Append the pre-install script cfgdata = cfgdata + b"\0" if

[issue3160] Building a Win32 binary installer crashes

New submission from Viktor Ferenczi <[EMAIL PROTECTED]>: Python 3.0b1, official MSI installer. Checkout source code of this project: http://code.google.com/p/anntools/ Enter into the root of your working copy and try to build a Win32 installer: C:\Python30\python.exe setup.py bdist_wininst NO