[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Changes by Terry J. Reedy : -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker ___ ___

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: New changeset 24c0c5b48cb996c3ec1800640edff2bfecc36275 by Terry Jan Reedy (Cheryl Sabella) in branch '3.6': [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3160) (#3162) https://github.com/python/cpython/commit/24c0c5b48cb996c3ec1800640edff2b

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Changes by Cheryl Sabella : -- pull_requests: +3198 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: Ditto backport for pr3160. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: New changeset 4bfebc63012f0f4e00f6a98c3d96e1c0ebe93408 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31206: IDLE: Factor HighPage class from ConfigDialog (#3160) https://github.com/python/cpython/commit/4bfebc63012f0f4e00f6a98c3d96e1c0ebe93408 -

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: New changeset 3d9c0d498de3245199ca95aba14ce260e7d33489 by Terry Jan Reedy (Cheryl Sabella) in branch '3.6': [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3156) (#3159) https://github.com/python/cpython/commit/3d9c0d498de3245199ca95aba14ce26

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Changes by Cheryl Sabella : -- pull_requests: +3196 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Changes by Cheryl Sabella : -- pull_requests: +3195 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: Ditto last message for PR3156 and 3rd patch deleting old code now dead. In retrospect, we could have done first and second patches together. Deleting or commenting out a large existing block along with other changes triggers the nonsense diff. Let's see if

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: New changeset 8f7a798edbdbca9a400105e3225463e59b334666 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31206: IDLE: Factor HighPage class from ConfigDialog (#3156) https://github.com/python/cpython/commit/8f7a798edbdbca9a400105e3225463e59b334666 -

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: New changeset 764e282158df0d7d6d7e0c72f38756c979a36539 by Terry Jan Reedy (Cheryl Sabella) in branch '3.6': [3.6] bpo-31206: IDLE: Factor HighPage class from ConfigDialog (GH-3141) (#3154) https://github.com/python/cpython/commit/764e282158df0d7d6d7e0c72f38756c

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Changes by Cheryl Sabella : -- pull_requests: +3193 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Changes by Cheryl Sabella : -- pull_requests: +3189 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: I cannot do the backport at the moment, so at your convenience, please run cherry picker for PR3141 for 3.6. You can submit the 2nd PR for 3.7 without waiting for me to merge the backport. -- ___ Python tracker

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: New changeset a32e40561a24de373d1c5a437a8aa329758ba8e4 by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-31206: IDLE: Factor HighPage class from ConfigDialog (#3141) https://github.com/python/cpython/commit/a32e40561a24de373d1c5a437a8aa329758ba8e4 -

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Changes by Cheryl Sabella : -- pull_requests: +3176 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: Delete frame.highlight_sample when frame becomes self. text = self.highlight_sample = frame.highlight_sample = Text( Change coverage to 95% when edit test file. -- ___ Python tracker

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Terry J. Reedy added the comment: The configdialog diff for #31205 was so jumbled that it did not apply correctly to 3.6. Let's do this in 2 PRs. First adds the class to how we think it should be. The second deletes the old code, makes any edits needed for the new class, and redirects the t

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

Changes by Terry J. Reedy : -- dependencies: +IDLE: Add tests for configdialog highlight tab ___ Python tracker ___ ___ Python-bugs-li

[issue31206] IDLE, configdialog: Factor out HighPage class from ConfigDialog

New submission from Terry J. Reedy: As with #31050, #31205 -- assignee: terry.reedy components: IDLE messages: 300278 nosy: csabella, terry.reedy priority: normal severity: normal stage: test needed status: open title: IDLE, configdialog: Factor out HighPage class from ConfigDialog type: