[issue31130] test_idle: idlelib.configdialog leaks references

STINNER Victor added the comment: > As I said, I only get the 1 block leak with a micro test of a class or method. Yeah, again, the memory block check is fragile. It might be an legit internal cache filled for good reasons. It can be a free list. It can be a lot of things. It's really hard to

[issue31130] test_idle: idlelib.configdialog leaks references

Terry J. Reedy added the comment: My message was most a heads-up. As I said, I only get the 1 block leak with a micro test of a class or method. It is possible that even that is Windows-specific. As long as you only care that test_idle not leak, I don't care about this either. --

[issue31130] test_idle: idlelib.configdialog leaks references

STINNER Victor added the comment: > test_idle leaked [1, 1, 1, 1] memory blocks, sum=4 While reference leaks are more or less stable, the check on memory blocks is fragile. I'm unable to reproduce your issue on Linux. I tested "./python -m test -R 3:3 -u gui -v test_idle". If you have a repro

[issue31130] test_idle: idlelib.configdialog leaks references

Terry J. Reedy added the comment: Victor: Something seems to have changed in the last few days. When I merged, both specific classes python -m test -R 3:3 -u gui -v test_idle -m idlelib.idle_test.test_configdialog.FontPageTest.* and the module as a whole passed. python -m test -R 3:3 -u gui -v

[issue31130] test_idle: idlelib.configdialog leaks references

STINNER Victor added the comment: The merged change is the correct fix. My change was only a workaround. Thanks for the fix Terry ;-) -- ___ Python tracker ___ _

[issue31130] test_idle: idlelib.configdialog leaks references

STINNER Victor added the comment: I confirm that test_idle doesn't leak anymore: $ ./python -m test -R 3:3 -u all test_idle 1 test OK. -- ___ Python tracker ___ ___

[issue31130] test_idle: idlelib.configdialog leaks references

Changes by Terry J. Reedy : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs

[issue31130] test_idle: idlelib.configdialog leaks references

Terry J. Reedy added the comment: New changeset 9d7d928b5853b921ed27f1e535dfe8174169854c by Terry Jan Reedy in branch '3.6': [3.6] bpo-31130: IDLE -- stop leaks in test_configdialog. (GH-3016) (#3018) https://github.com/python/cpython/commit/9d7d928b5853b921ed27f1e535dfe8174169854c --

[issue31130] test_idle: idlelib.configdialog leaks references

Changes by Terry J. Reedy : -- pull_requests: +3051 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31130] test_idle: idlelib.configdialog leaks references

Terry J. Reedy added the comment: New changeset 733d0f63c562090a2b840859b96028d6ec0a4803 by Terry Jan Reedy in branch 'master': bpo-31130: IDLE -- stop leaks in test_configdialog. (#3016) https://github.com/python/cpython/commit/733d0f63c562090a2b840859b96028d6ec0a4803 -- ___

[issue31130] test_idle: idlelib.configdialog leaks references

Terry J. Reedy added the comment: Attached is an improved idlelib.idle_test.test_* leak checker that uses the --match option. -- assignee: -> terry.reedy components: +IDLE, Tests nosy: +terry.reedy Added file: http://bugs.python.org/file47059/findleak.py __

[issue31130] test_idle: idlelib.configdialog leaks references

Changes by Terry J. Reedy : -- pull_requests: +3049 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31130] test_idle: idlelib.configdialog leaks references

Changes by STINNER Victor : -- pull_requests: +3047 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31130] test_idle: idlelib.configdialog leaks references

STINNER Victor added the comment: I don't know anything about idlelib, but it seems like the following patch fixes the failing test: diff --git a/Lib/idlelib/idle_test/test_configdialog.py b/Lib/idlelib/idle_test/test_configdialog.py index aff3c2f..9f495fd 100644 --- a/Lib/idlelib/idle_test/te

[issue31130] test_idle: idlelib.configdialog leaks references

Changes by STINNER Victor : -- versions: +Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31130] test_idle: idlelib.configdialog leaks references

New submission from STINNER Victor: Starting at the following build, test_idle started to leak references: http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%203.x/builds/60/steps/test/logs/stdio Example of leak: $ ./python -m test -R 3:3 -u all test_idle -m idlelib.idle_tes