[issue31065] Documentation for Popen.poll is unclear

Berker Peksag added the comment: I've backported 006617ff7d6df3fdedcfe53e94ee2c52cc796437 to 3.6. I think this can be closed now, thank you! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement versions: -Python 2.7 __

[issue31065] Documentation for Popen.poll is unclear

Berker Peksag added the comment: New changeset 0f1973d06e2116deafb19bbb9443b138187803c7 by Berker Peksag in branch '3.6': bpo-31065: Add doc about Popen.poll returning None. (GH-3169) https://github.com/python/cpython/commit/0f1973d06e2116deafb19bbb9443b138187803c7 -- nosy: +berker.p

[issue31065] Documentation for Popen.poll is unclear

Change by Berker Peksag : -- pull_requests: +4130 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue31065] Documentation for Popen.poll is unclear

Gregory P. Smith added the comment: New changeset 006617ff7d6df3fdedcfe53e94ee2c52cc796437 by Gregory P. Smith (Ivan Chernoff) in branch 'master': bpo-31065: Add doc about Popen.poll returning None. (#3169) https://github.com/python/cpython/commit/006617ff7d6df3fdedcfe53e94ee2c52cc796437

[issue31065] Documentation for Popen.poll is unclear

Changes by Elena Oat : -- pull_requests: -3258 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue31065] Documentation for Popen.poll is unclear

Changes by Elena Oat : -- pull_requests: +3258 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue31065] Documentation for Popen.poll is unclear

Elena Oat added the comment: I've added a sentence saying about the explicit return value. -- keywords: +patch nosy: +Elena.Oat Added file: http://bugs.python.org/file47102/issue31065.diff ___ Python tracker __

[issue31065] Documentation for Popen.poll is unclear

Ivan Chernov added the comment: Try to solve this issue, because it's pretty simple (: -- nosy: +vanadium23 ___ Python tracker ___ ___

[issue31065] Documentation for Popen.poll is unclear

Changes by Ivan Chernov : -- pull_requests: +3205 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue31065] Documentation for Popen.poll is unclear

R. David Murray added the comment: Agreed. Explicit is good. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31065] Documentation for Popen.poll is unclear

Mark Dickinson added the comment: > I don't there's I don't *think* there's ... Stupid fingers. -- ___ Python tracker ___ ___ Python

[issue31065] Documentation for Popen.poll is unclear

Mark Dickinson added the comment: Right, after following the source, I realise that `poll` is indeed returning `self.returncode` in all cases, and if the process hasn't terminated yet then `self.returncode` is still at its initial value of `None`. I can think of other ways that the result coul

[issue31065] Documentation for Popen.poll is unclear

R. David Murray added the comment: Yes we can add "otherwise return None". However it is pretty clear as is, since "poll" implies an immediate return, and if there's no return code to return, the logical value in Python to get back is None :) -- nosy: +r.david.murray

[issue31065] Documentation for Popen.poll is unclear

Changes by Mark Dickinson : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue31065] Documentation for Popen.poll is unclear

New submission from Mark Dickinson: The documentation for Popen.poll says: > Check if child process has terminated. Set and return returncode attribute. This requires the reader to guess that if the child process has not terminated, the call returns immediately, with a return value of ``None``