[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-23 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2880 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 5aa3bf041de5ee90ccbfcff103dcf3e54c5af237 by Terry Jan Reedy in branch '3.6': [3.6] bpo-30993: IDLE - Improve configdialog font page and tests. (GH-2818) (#2826) https://github.com/python/cpython/commit/5aa3bf041de5ee90ccbfcff103dcf3e54c5af237

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: A big issue with changing to tagging individual elements is back compatibility. Besides which, if the font is not bold, I cannot imaging bolding anything other than the definition names. This also seems to venture beyond 'keep IDLE simple for beginners'. Ho

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-23 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2878 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 07ba305a4c169e017e076e490a173a6f9b95b38e by Terry Jan Reedy in branch 'master': bpo-30993: IDLE - Improve configdialog font page and tests. (#2818) https://github.com/python/cpython/commit/07ba305a4c169e017e076e490a173a6f9b95b38e -- __

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-23 Thread Cheryl Sabella
Cheryl Sabella added the comment: +1 on the Font/Indent name. And I agree that the indent widget would make more sense on the General tab, or another name, like Editor/Shell Preferences. Another thought I had was Fonts should maybe be part of a Theme. At the theme level (not at the tag level

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Yes, test_font_set could be split up. But then the setup would have to be repeated for each, and it would be harder to verify that each .set() call was being tested the same way. The event graph for indent_scale is a simple linear chain, and the simple line

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am thinking that the tab title should be 'Font/Indent' rather than 'Font/Tabs' to avoid the confusion between the simulated file-folder tab that we click on and the tab key that indents. Opinions? But maybe the indent widget will be moved, eliminating the is

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-22 Thread Cheryl Sabella
Cheryl Sabella added the comment: Works on linux. I just had one question on github about a test for sizelist and moving the initialization of the Tk variables into setUp. I also deleted a second comment that was just a wrong comment, but it's led me to another question. For test_indent_scal

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-22 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2871 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Patch ready for test on linux and review. -- nosy: +csabella, louielu ___ Python tracker ___ ___ Pyt

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-22 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +2869 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30993] IDLE: Document and fix configdialog font tests.

2017-07-22 Thread Terry J. Reedy
New submission from Terry J. Reedy: This follows #30981 and the comments on PR 2805 after the close notice. * Causal chains in a directed acyclic graph link user actions to provisional entries in changes and and changes in the example displays. Explain these better in the docstring. Each font