[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Łukasz Langa : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Łukasz Langa added the comment: New changeset 8e572491b59c2334723bfd7411ab2a9fbd100f70 by Łukasz Langa in branch '3.6': [3.6] bpo-30983: [gdb] Fix py-bt, etc. for non-debug shared builds (GH-3153) (#3192) https://github.com/python/cpython/commit/8e572491b59c2334723bfd7411ab2a9fbd100f70 -

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Łukasz Langa : -- pull_requests: +3231 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Łukasz Langa added the comment: New changeset 5fe59f8e3a0a56a155c18f9d581205ec533764b6 by Łukasz Langa in branch 'master': bpo-30983: [gdb] Fix py-bt, etc. for non-debug shared builds (#3153) https://github.com/python/cpython/commit/5fe59f8e3a0a56a155c18f9d581205ec533764b6 -- ___

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Łukasz Langa : -- pull_requests: +3187 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Łukasz Langa : -- pull_requests: +3187, 3188 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Łukasz Langa added the comment: The issue originally stems from the fact that a non-debug Python build with --enable-shared is inlining PyEval_EvalFrameEx into _PyEval_EvalFrameDefault. So, the patch should really become to *replace* discovering PyEval_EvalFrameEx with the discovery of _PyEval

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

STINNER Victor added the comment: > You have to rebuild python for /Tools/gdb/libpython.py to land in /python-gdb.py. The latter is used during test_gdb.py. Ah yes, sorry, that's not obvious. "make" does the copy for you. -- ___ Python tracker

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Łukasz Langa added the comment: OK, I got the repro. You have to rebuild python for /Tools/gdb/libpython.py to land in /python-gdb.py. The latter is used during test_gdb.py. -- ___ Python tracker _

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Łukasz Langa added the comment: I am unable to repro this locally. With the changes to libpython.py test_gdb still passes on CentOS 7 and macOS 10.12. -- ___ Python tracker ___

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

STINNER Victor added the comment: While our CI is getting better everyday, it still has a few flaws. There is no automated buildbot failure notification to the author and committer yet because random failures were very common 6 months ago. I fixed something like 90% of the most common race condi

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Łukasz Langa added the comment: In this case it would be great if the buildbots commented on the relevant pull request that it broke the build. Otherwise this creates this dissonance that it was all green during merging of the PR when in fact it wasn't. I think we need to make test_gdb run on

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

STINNER Victor added the comment: New changeset 98e26979aa4c15b391fd3780340772a17d513d4d by Victor Stinner in branch '3.6': Revert "[3.6] bpo-30983: eval frame rename in pep 0523 broke gdb's python extension (GH-2803) (#3090)" (#3101) https://github.com/python/cpython/commit/98e26979aa4c15b391

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

STINNER Victor added the comment: New changeset 7cc33998b83df6ab8cf2c1afe16a61ee232e39ec by Victor Stinner in branch 'master': bpo-30983: Revert changes which broke most buildbots (#3100) https://github.com/python/cpython/commit/7cc33998b83df6ab8cf2c1afe16a61ee232e39ec -- ___

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

STINNER Victor added the comment: I chose to revert the change because I don't have the bandwidth right now to investigate why the change broke test_gdb. I'm surprised that a change affecting python-gdb.py wasn't properly tested manually using test_gdb.py :-( I understand that Travis CI doesn'

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by STINNER Victor : -- pull_requests: +3140 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by STINNER Victor : -- pull_requests: +3139 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

STINNER Victor added the comment: This change broke test_gdb on most buildbots :-( http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/1159/steps/test/logs/stdio == FAIL: test_pyup_command (test.test_gdb.

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Łukasz Langa : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-l

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Łukasz Langa added the comment: New changeset 09b77165e3fffa7b7ff160ad06042cdcfa004bf5 by Łukasz Langa in branch '3.6': [3.6] bpo-30983: eval frame rename in pep 0523 broke gdb's python extension (GH-2803) (#3090) https://github.com/python/cpython/commit/09b77165e3fffa7b7ff160ad06042cdcfa004bf

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Łukasz Langa : -- pull_requests: +3131 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Łukasz Langa : -- pull_requests: +3130 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Łukasz Langa added the comment: New changeset 2e0f4db114424a00354eab889ba8f7334a2ab8f0 by Łukasz Langa (Bruno "Polaco" Penteado) in branch 'master': bpo-30983: eval frame rename in pep 0523 broke gdb's python extension (#2803) https://github.com/python/cpython/commit/2e0f4db114424a00354eab889ba

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Cooper Lees : -- nosy: +cooperlees ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Bruno Penteado : -- pull_requests: +2853 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30983] eval frame rename in pep 0523 broke gdb's python extension

Changes by Bruno Penteado : -- title: eval frame rename in pep 0523 broke gdp's python extension -> eval frame rename in pep 0523 broke gdb's python extension ___ Python tracker ___