[issue30936] json module ref leaks detected by test_json

2017-07-16 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the fixes. I checked manually 2.7, 3.5, 3.6 and master branches with "./python -m test -R 3:3 test_json": no more leak! -- ___ Python tracker __

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for opening this issue Segev. Tests added in issue30911 exposed existing leak in 3.5 and 3.6. It was not exposed in 3.7 due to different code for sort_keys. But there was a leak when sorting keys is failed. I added a new test for this case. 2.7 is

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 45c471c04553d7e4cb5c328ea1ab02d6716f2bab by Serhiy Storchaka in branch '3.5': [3.5] bpo-30936: Fix a reference leak in json when fail to sort keys. (GH-2712). (#2728) https://github.com/python/cpython/commit/45c471c04553d7e4cb5c328ea1ab02d6716f

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a819e5e1e66a1a5f9a7073c8a1ff3c3f304c917b by Serhiy Storchaka in branch '3.6': [3.6] bpo-30936: Fix a reference leak in json when fail to sort keys. (GH-2712). (#2727) https://github.com/python/cpython/commit/a819e5e1e66a1a5f9a7073c8a1ff3c3f304c

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2788 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2787 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 49f6449ef4b81537c19b82329caaf60596c516c2 by Serhiy Storchaka in branch 'master': bpo-30936: Fix a reference leak in json when fail to sort keys. (#2712) https://github.com/python/cpython/commit/49f6449ef4b81537c19b82329caaf60596c516c2

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread STINNER Victor
STINNER Victor added the comment: On Python 3.6, the leaking test is: test.test_json.test_speedups.TestEncode.test_bad_bool_args -- ___ Python tracker ___ __

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: -> patch review versions: +Python 2.7, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2776 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Segev Finer
New submission from Segev Finer: >From builtbots: test_json leaked [4, 4, 4] references, sum=12 test_json leaked [3, 3, 3] memory blocks, sum=9 1 test failed again: test_json Probably unearthed by: https://github.com/python/cpython/pull/2692 https://github.com/python/cpython/pull/2693