[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: If you have more annotations to add now, go ahead and I will review. -- ___ Python tracker ___ ___ P

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-14 Thread Cheryl Sabella
Cheryl Sabella added the comment: Did you want me to do other PRs for this? I had intended that one to be the first and I would complete more information on a subsequent PR, but you've added a lot of info. -- ___ Python tracker

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 9a09c667cf133e722a3e7ed2185f3e9e5af25a99 by terryjreedy in branch '3.6': [3.6] bpo-30913: IDLE: Document tk vars, attributes, and methods for ConfigDialog (GH-2697) (#2702) https://github.com/python/cpython/commit/9a09c667cf133e722a3e7ed2185f3e9e

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: We can edit details as we examine functions to test and change or refactor. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker __

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-13 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- pull_requests: +2768 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 36329a4dd85c03e2060a306e86ac5ddec6fd2549 by terryjreedy (csabella) in branch 'master': bpo-30913: IDLE: Document tk vars, attributes, and methods for ConfigDialog (#2697) https://github.com/python/cpython/commit/36329a4dd85c03e2060a306e86ac5ddec6

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: I added missing functions and created attached list with help of Find in (1) Files. -- Added file: http://bugs.python.org/file47013/configdialog_funcs.txt ___ Python tracker _

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-13 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +2763 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-12 Thread Terry J. Reedy
Terry J. Reedy added the comment: 16 methods so far, + 17 var_changed_x is 35, leaving another 29. If you are going to give the whole widget structure, then an '*' before bound names would be sufficient and avoid the duplication. -- ___ Python track

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-12 Thread Cheryl Sabella
Cheryl Sabella added the comment: I did a first draft of the four create_page_* methods. I did one additional section called 'Widget Structure' which has the names of the widgets indented under the parent widget they are attached to. I don't know if that would be helpful. The order of the c

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-12 Thread Terry J. Reedy
Terry J. Reedy added the comment: You put one non-tk name in the font page 'Configuration attributes'. I removed it as not belonging with the tk Vars, but it got me thinking that more would be useful. In the ConfigChanges docstring we included a list of methods, which I believe is recommende

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-12 Thread Cheryl Sabella
Cheryl Sabella added the comment: I had actually started doing this a little in the original docstrings and then was worried that it was too redundant with the code. Thanks for mentioning the multiple PRs. I'll take a look at it and make one change at a time for easier review. --

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-12 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: +Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30913] IDLE: Document tk Vars, attributes, methods by tab page

2017-07-12 Thread Terry J. Reedy
New submission from Terry J. Reedy: Among other things, #30777 added docstrings to configdialog. Those for create_page_x methods included a list of 'Configuration attributes' (Tk Variables) with an annotation as to what the Var represents. The list for the font tab already helped when writin