[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Terry J. Reedy : -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker ___ ___

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: I am closing this as basically complete. I opened #30981 to add and perhaps complete font page tests. -- ___ Python tracker ___ __

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: New changeset 42abf7f9737f78a5da311a42945d781dfcd6c6c0 by terryjreedy in branch '3.6': [3.6] bpo-30870: IDLE: Add configdialog fontlist selection unittest (GH-2666) (#2701) https://github.com/python/cpython/commit/42abf7f9737f78a5da311a42945d781dfcd6c6c0 ---

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Terry J. Reedy : -- pull_requests: +2767 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: New changeset 9b622fb90331f259894e6edb29b5c64b9366491a by terryjreedy (Louie Lu) in branch 'master': bpo-30870: IDLE: Add configdialog fontlist selection unittest (#2666) https://github.com/python/cpython/commit/9b622fb90331f259894e6edb29b5c64b9366491a --

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: PR2666 adds 4% test coverage. 40% left to go. I expect some tests will cover more lines with less code. I am working on a test for set_font_sample. -- ___ Python tracker __

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: Serhiy: question about tkinter.wantobjects. ConfigDialog sets the font options of label font_sample and text text_highlight_sample with a font tuple such as font=('courier', 12, ''). In the test, I expected retrieval of the font option with sample_font

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: The new gui tests passed on Travis (linux), which I strongly suspect does not run gui tests. The generate key test failed on Appveyor (Windows), which means is does run gui tests. It also failed on my machine: generate key release did not work. The generate

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Louie Lu : -- pull_requests: +2732 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Louie Lu added the comment: configdialog misuse `self.withdraw` at init, it should be `self.wm_withdraw`, #30900 fix this problem. After that, it should be a success to use event_generate in configdialog unittest with no `self.withdraw`. -- ___ Pyth

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Louie Lu added the comment: It seem setUpModule will smash out the test, I've add a trust-will-work test inside the test_configdialog.py: class Test(unittest.TestCase): def setUp(self): self.root = tkinter.Tk() def test_test(self): self.root.bind('', lambda x: print('te

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Louie Lu added the comment: It just get wierd, I can't do event_generate with Terry, too. Attach poc.py that should print out a 'testing', but it didn't. -- Added file: http://bugs.python.org/file47006/tests.py ___ Python tracker

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: New changeset 953e527763f5af293668135acdf5f0a20c3f6f4f by terryjreedy in branch '3.6': [3.6] bpo-30870: IDLE -- fix logic error in eae2537. (GH-2660) (#2661) https://github.com/python/cpython/commit/953e527763f5af293668135acdf5f0a20c3f6f4f -- ___

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Terry J. Reedy : -- pull_requests: +2726 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: New changeset 5b62b35e6fcba488da2f809965a5f349a4170b02 by terryjreedy in branch 'master': bpo-30870: IDLE -- fix logic error in eae2537. (#2660) https://github.com/python/cpython/commit/5b62b35e6fcba488da2f809965a5f349a4170b02 --

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: I believe I read somewhere (SO?) that root.withdraw sometimes affects the effectiveness of event_generate. I will try de-iconifying for just this. -- ___ Python tracker _

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: My manual test procedure was faulty. Without a unit test, I should have asked for another person to verify. -- ___ Python tracker ___

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Terry J. Reedy : -- pull_requests: +2725 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Serhiy Storchaka added the comment: I don't know how to make the testing code working. -- ___ Python tracker ___ ___ Python-bugs-list

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Serhiy Storchaka added the comment: It isn't my. It was added by Guilherme in r69050. I'll take a look at code tomorrow. -- ___ Python tracker ___ __

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: Serhiy, I tried tkinter.test.support.simulate_mouse_click to test this patch but it seems not to work. Code at end of previous message. Any idea on how to fix? -- nosy: +serhiy.storchaka stage: patch review -> test needed

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: We already know that setting StringVar font_name triggers a change to changes. We also know that manually clicking or Up or Down triggers <>, which sets font_name and redraws the box. The challenge is to do something that will trigger the virtual event. The

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: New changeset 7ab334233394070a25344d481c8de1402fa12b29 by terryjreedy in branch '3.6': [3.6] bpo-30870: IDLE: Change sample font when select by key-up/down (GH-2617) (#2640) https://github.com/python/cpython/commit/7ab334233394070a25344d481c8de1402fa12b29 --

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Terry J. Reedy : -- pull_requests: +2705 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: If one scrolls with the mousewheel or scrollbar, the selection does not change and the example should not change, and I presume it will not with the patch. If one presses up or down, the selection does change, just as if one clicked, and the example should ch

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Terry J. Reedy added the comment: New changeset bb2bae84d6b29f991b757b46430c3c15c60059e9 by terryjreedy (Louie Lu) in branch 'master': bpo-30870: IDLE: Change sample font when select by key-up/down (#2617) https://github.com/python/cpython/commit/bb2bae84d6b29f991b757b46430c3c15c60059e9 -

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Terry J. Reedy : -- stage: -> patch review type: -> enhancement versions: +Python 3.6 ___ Python tracker ___ ___ Python-b

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

Changes by Louie Lu : -- pull_requests: +2683 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30870] IDLE: configdialog/fonts: change font when select by key up/down

New submission from Louie Lu: Add event for KeyRelease-Up and KeyRelease-Down to change sample font. Current code only changed font when using button-click on listbox. -- assignee: terry.reedy components: IDLE messages: 297867 nosy: louielu, terry.reedy priority: normal severity: normal