[issue30868] IDLE: Improve configuration tests with mock Save.

2017-07-09 Thread Cheryl Sabella
Cheryl Sabella added the comment: `git log` is the magic command. I won't be able to do it justice because it has too many options, but here are a few. `git log` shows all commit message history on the current branch. `git log -p` (p for patch) shows the actual diffs `git log -p -- path/to/fil

[issue30868] IDLE: Improve configuration tests with mock Save.

2017-07-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: This issue began with #27173 which added test_config with CurrentColorKeysTest to test the new IdleConf.current_colors_and_keys. Those tests never called any user parser.Save, but I knew I had to remove the possibility that any future test would touch anyone'

[issue30868] IDLE: Improve configuration tests with mock Save.

2017-07-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: Very helpful. Is there a git equivalent to hg annotate, or did you have to trudge through the commit log? -- ___ Python tracker ___ __

[issue30868] IDLE: Improve configuration tests with mock Save.

2017-07-08 Thread Cheryl Sabella
Cheryl Sabella added the comment: If it's helpful, here's some history on Save and save_as in configdialog. -- Item: Code change which added the lines to always save 'highlight' and 'keys'. November 16, 2004, commit 5acdf9308191b6356fb3ed4ba691ba5cd391f202 commit message: Saving a

[issue30868] IDLE: Improve configuration tests with mock Save.

2017-07-06 Thread Terry J. Reedy
New submission from Terry J. Reedy: When writing tests for config and configdialog, I blocked the user configs from hitting the filesystem by passing '' as the file name. This disables the Save function. To know that Save is called, a mock is needed. To know what would have been written to