[issue30860] Consolidate stateful C globals under a single struct.

STINNER Victor added the comment: New changeset 9e87e7776f7ace66baaf7247233afdabd00c2b44 by Victor Stinner in branch 'master': bpo-32096: Remove obj and mem from _PyRuntime (#4532) https://github.com/python/cpython/commit/9e87e7776f7ace66baaf7247233afdabd00c2b44 -- _

[issue30860] Consolidate stateful C globals under a single struct.

Change by STINNER Victor : -- pull_requests: +4468 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue30860] Consolidate stateful C globals under a single struct.

STINNER Victor added the comment: New changeset ccb3c7654cc3d031fb93bf443a6ef9cfb11f6b43 by Victor Stinner in branch 'master': bpo-30860: Fix deadcode in obmalloc.c (#3499) https://github.com/python/cpython/commit/ccb3c7654cc3d031fb93bf443a6ef9cfb11f6b43 -- __

[issue30860] Consolidate stateful C globals under a single struct.

Eric Snow added the comment: New changeset dae0276bb6bc7281d59fb0b8f1aab31634ee80dc by Eric Snow in branch 'master': bpo-30860: Fix a refleak. (#3567) https://github.com/python/cpython/commit/dae0276bb6bc7281d59fb0b8f1aab31634ee80dc -- ___ Python t

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- pull_requests: +3556 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue30860] Consolidate stateful C globals under a single struct.

Eric Snow added the comment: New changeset fc1bf872e9d31f3e837f686210f94e57ad3d6582 by Eric Snow in branch 'master': bpo-30860: Move windows.h include out of internal/*.h. (#3458) https://github.com/python/cpython/commit/fc1bf872e9d31f3e837f686210f94e57ad3d6582 -- ___

[issue30860] Consolidate stateful C globals under a single struct.

STINNER Victor added the comment: New changeset 8728018624f257c7cfe44014742ae46134047f49 by Victor Stinner (Eric Snow) in branch 'master': bpo-30860: Fix a refleak. (#3506) https://github.com/python/cpython/commit/8728018624f257c7cfe44014742ae46134047f49 -- __

[issue30860] Consolidate stateful C globals under a single struct.

Eric Snow added the comment: New changeset ba6d5d1defd7a281c8c8804e4b4cfd7370886236 by Eric Snow in branch 'master': bpo-30860: Always provide serialno. (#3507) https://github.com/python/cpython/commit/ba6d5d1defd7a281c8c8804e4b4cfd7370886236 -- __

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- pull_requests: +3501 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- pull_requests: +3499 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue30860] Consolidate stateful C globals under a single struct.

STINNER Victor added the comment: New changeset 4866957e86594935ec2e6434b6e470ebeb0c79b4 by Victor Stinner in branch 'master': bpo-30860: Add Include/internal/ in "make tags" (#3498) https://github.com/python/cpython/commit/4866957e86594935ec2e6434b6e470ebeb0c79b4 --

[issue30860] Consolidate stateful C globals under a single struct.

STINNER Victor added the comment: The commit 2ebc5ce42a8a9e047e790aefbf9a94811569b2b6 introduced reference leaks: see bpo-31420 which tracks them. -- ___ Python tracker ___ ___

[issue30860] Consolidate stateful C globals under a single struct.

Changes by STINNER Victor : -- pull_requests: +3493 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30860] Consolidate stateful C globals under a single struct.

Changes by STINNER Victor : -- pull_requests: +3492 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30860] Consolidate stateful C globals under a single struct.

Eric Snow added the comment: FYI, the merged code introduced a bunch of new warnings on Windows. I'm looking into it. -- ___ Python tracker ___ ___

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- keywords: +patch pull_requests: +3452 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30860] Consolidate stateful C globals under a single struct.

Eric Snow added the comment: New changeset 2ebc5ce42a8a9e047e790aefbf9a94811569b2b6 by Eric Snow in branch 'master': bpo-30860: Consolidate stateful runtime globals. (#3397) https://github.com/python/cpython/commit/2ebc5ce42a8a9e047e790aefbf9a94811569b2b6 -- _

[issue30860] Consolidate stateful C globals under a single struct.

Nick Coghlan added the comment: Regarding the accidental exposure of _Py_CheckRecursionLimit, the main active usage of the stable ABI that we're aware of is Riverbank's C/C++ binding generator for PyQt: http://pyqt.sourceforge.net/Docs/sip4/directives.html#directive-%Module (see the use_limit

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- pull_requests: +3403 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30860] Consolidate stateful C globals under a single struct.

Eric Snow added the comment: New changeset 05351c1bd8b70d1878527762174cdaaba3572395 by Eric Snow in branch 'master': Revert "bpo-30860: Consolidate stateful runtime globals." (#3379) https://github.com/python/cpython/commit/05351c1bd8b70d1878527762174cdaaba3572395 --

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- pull_requests: -3387 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- pull_requests: +3388 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- pull_requests: +3387 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30860] Consolidate stateful C globals under a single struct.

Benjamin Peterson added the comment: I'm also a bit skeptical about the header design in this PR. We should not to have a monolithic _Python.h header, and it should not be sometimes included in Python.h. Rather, code that needs the internal headers should include them directly. In fact, this P

[issue30860] Consolidate stateful C globals under a single struct.

STINNER Victor added the comment: Sadly, Windows doesn't like much your big change. Just one example: 2>C:\buildbot.python.org\3.x.kloth-win64\build\Include\Python-ast.h(563): warning C4005: 'Yield': macro redefinition [C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\pythoncore.vcxp

[issue30860] Consolidate stateful C globals under a single struct.

Eric Snow added the comment: New changeset 76d5abc8684bac4f2fc7cccfe2cd940923357351 by Eric Snow in branch 'master': bpo-30860: Consolidate stateful runtime globals. (#2594) https://github.com/python/cpython/commit/76d5abc8684bac4f2fc7cccfe2cd940923357351 -- _

[issue30860] Consolidate stateful C globals under a single struct.

Nick Coghlan added the comment: The core motivation driving the original refactoring was to better understand and consolidate our runtime state in order to clarify what the GIL is actually protecting (aside from the reference counts). That then turned out to have surprising performance benefit

[issue30860] Consolidate stateful C globals under a single struct.

Antoine Pitrou added the comment: After looking at the PR, I'm a bit skeptical about this. Suddenly a lot of things which are implementation details get moved to the public include files, which makes things more confusing from my POV. I also don't know why all globals should be consolidated

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue30860] Consolidate stateful C globals under a single struct.

Serhiy Storchaka added the comment: See also issue29881. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailin

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Eric Snow : -- pull_requests: +2665 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30860] Consolidate stateful C globals under a single struct.

Eric Snow added the comment: One thing I'd like to also try is to use a freelist embedded in _PyRuntimeState for the PyInterpreterState and PyThreadState linked lists. -- ___ Python tracker ___

[issue30860] Consolidate stateful C globals under a single struct.

New submission from Eric Snow: CPython's C code makes extensive use of global variables. The globals fall into one of several categories: * (effectively) constants (incl. static types) * freelists, caches, and counters * used exclusively in main or in REPL * process-global state * module state