[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2020-04-01 Thread Anthony Sottile
Change by Anthony Sottile : -- nosy: +Anthony Sottile nosy_count: 6.0 -> 7.0 pull_requests: +18644 pull_request: https://github.com/python/cpython/pull/10021 ___ Python tracker ___

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2019-04-23 Thread STINNER Victor
STINNER Victor added the comment: New changeset 8a9a6b443c57e47e9d10ed7775479aada4dac719 by Victor Stinner in branch '3.7': [3.7] bpo-9566: Fix compiler warnings on Windows (GH-12920) https://github.com/python/cpython/commit/8a9a6b443c57e47e9d10ed7775479aada4dac719 -- nosy: +vstinne

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2019-04-23 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12847 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2018-04-30 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset fb7e7992beec7f76cc2db77ab6ce1e86446bfccf by Łukasz Langa (Victor Stinner) in branch 'master': bpo-30465: Fix C downcast warning on Windows in ast.c (#6593) https://github.com/python/cpython/commit/fb7e7992beec7f76cc2db77ab6ce1e86446bfccf

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2018-04-25 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +6291 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-10-04 Thread Eric V. Smith
Eric V. Smith added the comment: I think it's fixed. Closing. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-10-02 Thread Ned Deily
Ned Deily added the comment: Is there more to do on this issue or can it be closed now? -- nosy: +ned.deily ___ Python tracker ___ _

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-09-06 Thread Eric V. Smith
Eric V. Smith added the comment: New changeset aa1afc72c1ee1f090e6302198d9a0295f1ce1c05 by ericvsmith (Miss Islington (bot)) in branch '3.6': bpo-30465: Fix lineno and col_offset in fstring AST nodes (GH-1800) (gh-3409) https://github.com/python/cpython/commit/aa1afc72c1ee1f090e6302198d9a0295f1

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-09-06 Thread Roundup Robot
Changes by Roundup Robot : -- pull_requests: +3410 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-09-06 Thread Eric V. Smith
Eric V. Smith added the comment: New changeset e7c566caf177afe43b57f0b2723e723d880368e8 by ericvsmith (Łukasz Langa) in branch 'master': bpo-30465: Fix lineno and col_offset in fstring AST nodes (#1800) https://github.com/python/cpython/commit/e7c566caf177afe43b57f0b2723e723d880368e8

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-09-05 Thread Eric V. Smith
Eric V. Smith added the comment: See also issue 31140: I'm not sure if that case is covered by this issue. -- ___ Python tracker ___ _

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-06-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg296115 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-06-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg296114 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-06-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It causes segfault also with unpatched Python. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-06-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The last example causes a segfault with current PR. >>> import ast >>> ast.parse(r""" ... f'''\ ... \ ... {x}\ ... \ ... ''' ... """) python: Python/ast.c:4994: FstringParser_ConcatFstring: Assertion `!state->last_str || PyUnicode_GET_LENGTH(state->last_str)

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-05-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have concerns about following cases. * f-string containing multiple equivalent subexpressions: f'{x} {x}' or f''' {x} {x} ''' * f-string containing escaped newlines: f'''\ \ {x}\ \ ''' The tests look slightly verbose and fragile to me. If once the pars

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-05-24 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks for adding so many tests. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-05-24 Thread Łukasz Langa
Changes by Łukasz Langa : -- pull_requests: +1883 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue30465] FormattedValue expressions have wrong lineno and col_offset information

2017-05-24 Thread Łukasz Langa
New submission from Łukasz Langa: f-strings are computed in a separate compiler step. This makes their lineno and col_offset information wrong. This is problematic for flake8 which reports problems inside f-strings on the wrong line (typically the first one). Attached patch fixes the issue. -