[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Serhiy Storchaka added the comment: New changeset c97c1914f401359f2a7e6c8e0364e71ad9fb5bc8 by Serhiy Storchaka in branch '3.5': [3.5] bpo-30065: Fixed arguments validation in _posixsubprocess.fork_exec(). (GH-1110) (#1190) https://github.com/python/cpython/commit/c97c1914f401359f2a7e6c8e0364e7

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Changes by Serhiy Storchaka : -- pull_requests: +1318 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Serhiy Storchaka added the comment: New changeset e2546172622dd52692cf0e26c2b931f942f345b6 by Serhiy Storchaka in branch '3.6': [3.6] bpo-30065: Fixed arguments validation in _posixsubprocess.fork_exec(). (GH-1110) (#1186) https://github.com/python/cpython/commit/e2546172622dd52692cf0e26c2b931

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Changes by Serhiy Storchaka : -- pull_requests: +1315 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Serhiy Storchaka added the comment: New changeset 66bffd1663489d080349debbf1b472d432351038 by Serhiy Storchaka in branch 'master': bpo-30065: Fixed arguments validation in _posixsubprocess.fork_exec(). (#1110) https://github.com/python/cpython/commit/66bffd1663489d080349debbf1b472d432351038 -

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Serhiy Storchaka added the comment: It is hard to reproduce (especially the second issue) since in all cases in the stdlib a list passed to fork_exec() is just created by sorted() and doesn't have other references. But if someone is so insane that passes int-like objects with non-idempotent __

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Gregory P. Smith added the comment: nice find. did anyone's code actually run into this issue? -- nosy: +gregory.p.smith ___ Python tracker ___ _

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

Changes by Serhiy Storchaka : -- pull_requests: +1251 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30065] Insufficient validation in _posixsubprocess.fork_exec()

New submission from Serhiy Storchaka: _posixsubprocess.fork_exec() takes a sequence of file descriptors. It first validates it, and since the validation is passed uses it without checking for errors. But since __len__, __getitem__ and __int__ can execute user code and release GIL, errors can o