[issue3002] shutil.copyfile blocks indefinitely on named pipes

Antoine Pitrou added the comment: Committed in r72178, r72179. Thanks! -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Antoine Pitrou added the comment: I forgot the case where the /destination/ file is a named pipe. Here is a new patch. -- message_count: 8.0 -> 9.0 Added file: http://bugs.python.org/file13270/issue3002-2.patch ___ Python tracker

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Antoine Pitrou added the comment: Here is a patch, introducing a new exception named SpecialFileError which is raised when trying to copy a named pipe. Other kinds of special file aren't checked for, but they could it we thought it's sensible to do so. -- keywords: +patch message_count:

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Antoine Pitrou added the comment: I'm not sure the race condition possibility is important. Is shutil.copytree() protected against such race conditions in the first place? (I'd argue this bug is less about potential DOS attacks than the simple unfriendliness of indefinitely blocking) -

[issue3002] shutil.copyfile blocks indefinitely on named pipes

François Granade added the comment: Note that the 'cp' user command in Linux blocks also. Although this is *very* painful, you could argue that since the OS commands do the same thing, it shouldn't be fixed. -- nosy: +farialima ___ Python tracker

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: release blocker -> critical ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Ralf Schmitt <[EMAIL PROTECTED]> added the comment: if the destination is a named pipe, it will also block (waiting for a reader). ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Ralf Schmitt <[EMAIL PROTECTED]> added the comment: The open('fifo', 'rb') already blocks. One has to use os.fdopen with O_NONBLOCK to prevent blocking. fd=os.open('fifo', os.O_RDONLY | os.O_NONBLOCK) and then use stat.S_ISFIFO(os.fstat(fd).st_mode) to check if this is a fifo. Checking with o

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Changes by Georg Brandl <[EMAIL PROTECTED]>: -- priority: -> critical versions: +Python 3.0 -Python 2.3, Python 2.4 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Ralf Schmitt <[EMAIL PROTECTED]> added the comment: I can confirm this issue on python 2.5. I think the priority should be set to critical, as this can lead to denial of service attacks. -- nosy: +schmir versions: +Python 2.4, Python 2.5, Python 2.6 _

[issue3002] shutil.copyfile blocks indefinitely on named pipes

Raghuram Devarakonda <[EMAIL PROTECTED]> added the comment: I am not sure if copyfile() should be trying to copy named pipes (or any other special files for that matter). The best way is perhaps to check and skip such files. -- nosy: +draghuram ___ Py

[issue3002] shutil.copyfile blocks indefinitely on named pipes

New submission from albert hofkamp <[EMAIL PROTECTED]>: shutil.copytree() uses shutil.copyfile() to copy files recursively. shutil.copyfile() opens the source file for reading, and the destination file for writing, followed by a call to shutil.copyfileobj(). If the file happens to be a named pip