[issue29970] Severe open file leakage running asyncio SSL server

Andrew Svetlov added the comment: Don't know. Ask other coredevs maybe? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29970] Severe open file leakage running asyncio SSL server

Yury Selivanov added the comment: > The fix introduces a new parameter in public API. Maybe we can get away with this if we do not document it in 3.6 and add a comment to the source code that using this new parameter will make the code incompatible with earlier 3.6.x versions? -- __

[issue29970] Severe open file leakage running asyncio SSL server

Andrew Svetlov added the comment: The fix introduces a new parameter in public API. That's why I think we shouldn't backport it. -- ___ Python tracker ___

[issue29970] Severe open file leakage running asyncio SSL server

Yury Selivanov added the comment: Should we backport this to 3.6? This is a security issue. -- ___ Python tracker ___ ___ Python-bu

[issue29970] Severe open file leakage running asyncio SSL server

Andrew Svetlov added the comment: New changeset 51eb1c6b9c0b382dfd6e0428eacff0c7891a6fc3 by Andrew Svetlov in branch 'master': bpo-29970: Make ssh_handshake_timeout None by default (#4939) https://github.com/python/cpython/commit/51eb1c6b9c0b382dfd6e0428eacff0c7891a6fc3 -- _

[issue29970] Severe open file leakage running asyncio SSL server

Change by Andrew Svetlov : -- pull_requests: +4830 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29970] Severe open file leakage running asyncio SSL server

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5, Python 3.6 ___ Python tracker ___

[issue29970] Severe open file leakage running asyncio SSL server

Andrew Svetlov added the comment: Fixed in 3.7 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29970] Severe open file leakage running asyncio SSL server

Andrew Svetlov added the comment: New changeset f7686c1f5553b24e3307506a18e18f6544de94d3 by Andrew Svetlov (Neil Aspinall) in branch 'master': bpo-29970: Add timeout for SSL handshake in asyncio https://github.com/python/cpython/commit/f7686c1f5553b24e3307506a18e18f6544de94d3 -- nosy

[issue29970] Severe open file leakage running asyncio SSL server

Change by Neil Aspinall : -- keywords: +patch pull_requests: +4717 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue29970] Severe open file leakage running asyncio SSL server

Neil Aspinall added the comment: I think there's been some confusion about what PR 480 was meant to fix - it helps in cases where connections are closed during handshake, but if a server connection is waiting for a handshake but never receives any data at all then it stays in that state forev

[issue29970] Severe open file leakage running asyncio SSL server

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue29970] Severe open file leakage running asyncio SSL server

kyuupichan added the comment: I'm not sure what you mean about this being a server-specific problem. It's clearly a bug in the asyncio SSL wrapper as using TCP instead of SSL with otherwise identical code doesn't leak open files. -- ___ Python tra

[issue29970] Severe open file leakage running asyncio SSL server

Nikolay Kim added the comment: I see. this is server specific problem. as a temp solution I'd use proxy for ssl termination. -- ___ Python tracker ___ __

[issue29970] Severe open file leakage running asyncio SSL server

kyuupichan added the comment: @Nikolay Kim As I note in the original submission, 480 was tested and does NOT solve this issue. Thanks. -- ___ Python tracker ___ __

[issue29970] Severe open file leakage running asyncio SSL server

Nikolay Kim added the comment: question is, should asyncio handle timeouts or leave it to caller? https://github.com/python/cpython/pull/480 fixes leak during handshake. -- nosy: +fafhrd91 ___ Python tracker _

[issue29970] Severe open file leakage running asyncio SSL server

Yury Selivanov added the comment: I'm assigning this to myself to make sure I don't forget about this. If someone wants to tackle this please feel free to reassign. -- assignee: -> yselivanov versions: +Python 3.7 ___ Python tracker

[issue29970] Severe open file leakage running asyncio SSL server

Changes by Brett Cannon : -- nosy: +giampaolo.rodola, haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue29970] Severe open file leakage running asyncio SSL server

New submission from kyuupichan: Original report at old repo here: https://github.com/python/asyncio/issues/483 There this is reported fixed by https://github.com/python/cpython/pull/480 I wish to report that whilst the above patch might have a small positive effect, it is far from solving the