[issue29776] Modernize properties

2017-03-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset bdf6b910f9ea75609caee498a975af03b6d23f67 by Serhiy Storchaka in branch 'master': bpo-29776: Use decorator syntax for properties. (#585) https://github.com/python/cpython/commit/bdf6b910f9ea75609caee498a975af03b6d23f67 -- _

[issue29776] Modernize properties

2017-03-18 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue29776] Modernize properties

2017-03-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have checked and none from replaced function is used. But just for the case I reverted changes for Lib/xml/dom/. Here used more complex logic for generating other properties. -- ___ Python tracker

[issue29776] Modernize properties

2017-03-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I replaced only private getters and setters. All tests passed. -- ___ Python tracker ___ ___ Pytho

[issue29776] Modernize properties

2017-03-09 Thread Ethan Furman
Ethan Furman added the comment: Have you made sure nothing calls the replaced functions manually? Such as: ... self._set_foo(9) ... -- nosy: +ethan.furman ___ Python tracker __

[issue29776] Modernize properties

2017-03-09 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +482 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue29776] Modernize properties

2017-03-09 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Following PR updates Python sources to use new shiny syntax for properties. It replaces the old code def _foo(self): ... def _set_foo(self, value): ... foo = property(_foo, _set_foo) with the new code @property def fo